Merged
Conversation
Contributor
|
👋 @Maayan-s |
elongl
reviewed
Apr 9, 2023
| ) | ||
| return | ||
|
|
||
| logger.info( |
Contributor
There was a problem hiding this comment.
Maybe we should just drop this log?
I tend to think that it's more confusing to the user rather than valuable information.
Contributor
Author
There was a problem hiding this comment.
I thought about this, but it could help us when debugging problems for users.
Also, I think that when they run the tool it's overall positive that they see progress and don't think it's stuck.
elongl
reviewed
Apr 9, 2023
| logger.warning( | ||
| f"You are using incompatible versions between edr ({py_pkg_ver}) and Elementary's dbt package ({dbt_pkg_ver}).\n " | ||
| "To fix please run:\n" | ||
| "pip install elementary-data --upgrade\n", |
Contributor
There was a problem hiding this comment.
pip install [options] <requirement specifier> [package-index-options] ...
The --upgrade needs to be before the package name.
Suggested change
| "pip install elementary-data --upgrade\n", | |
| "pip install --upgrade elementary-data\n", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.