Conversation
we expected an empty list but subscribers can be sometimes `None`
Contributor
|
👋 @RoiTabach |
IDoneShaveIt
previously approved these changes
Mar 22, 2023
elementary/utils/json_utils.py
Outdated
| def list_of_lists_of_strings_to_comma_delimited_unique_strings( | ||
| list_of_strings: List[List[str]], prefix: Optional[str] = None | ||
| ) -> str: | ||
| list_of_strings = [x for x in list_of_strings if x] # filter Nones and empty lists |
Contributor
There was a problem hiding this comment.
Why would we have an empty string / None / empty list in the list?
Contributor
Author
There was a problem hiding this comment.
Result of Alert Normalization. I expected it to be an empty list but seems it is None in some edge cases
Empty list doesn't bother us l downstream but if we're already filtering None values it makes sense to filter them as well
RoiTabach
commented
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we expected an empty list but subscribers can be sometimes
None