You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
re opening to fix git commit mayham.
Coments from prev CR:
Or - add a unit test
Idan - make "warning" be in elif and the everything else should be skipped
Describe the bug
In the slack message that is sent with the report, we count correctly which of the tests are passed/failed/warning. However, when creating the details section, we count passed tests along with the warnings.
To Reproduce
Steps to reproduce the behavior:
Run dbt and have a small number of Passing tests. (I added a not_null test on the one model from our integration tests and ran dbt build -s one
Run edr monitor send-report
Look at the summary numbers
See the passed tests are counted properly but listed with the Warnings.
Expected behavior
No details for passed tests.
Screenshots
Environment (please complete the following information):
edr Version: [e.g. 0.5.3], can be found by running pip show elementary-data
dbt package Version: [e.g. 0.4.1], can be found in packages.yml file
Additional context
Raised in Slack thread https://elementary-community.slack.com/archives/C02CTC89LAX/p1678878540310359
I believe the fact we truncate the report on Slack if it's got too many items caused us to not see it even tho it was there for a long time - since we usually test with 100+ issues so the details view is usually not seen.
👋 @RoiTabach
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re opening to fix git commit mayham.
Coments from prev CR:
Or - add a unit test
Idan - make "warning" be in
elifand the everything else should be skipped