ELE 518 Don't add details of Passed tests in Warnings

.github/workflows/test-github-action.yml

@@ -93,11 +93,11 @@ jobs:
         uses: actions/upload-artifact@v3
         with:
           name: report.html
-          path: report.html
+          path: edr_target/report.html
 
       - name: Upload log
         if: always()
         uses: actions/upload-artifact@v3
         with:
           name: edr.log
-          path: edr.log
+          path: edr_target/edr.log

.github/workflows/test-warehouse.yml

@@ -174,7 +174,7 @@ jobs:
         uses: actions/upload-artifact@v3
         with:
           name: report_${{ inputs.warehouse-type }}_${{ env.BRANCH_NAME }}.html
-          path: elementary/elementary_report.html
+          path: elementary/edr_target/elementary_report.html
 
       - name: Write GCS keyfile
         env:
@@ -207,7 +207,7 @@ jobs:
         uses: actions/upload-artifact@v3
         with:
           name: edr.log
-          path: elementary/edr.log
+          path: elementary/edr_target/edr.log
 
       - name: Run Python package e2e tests
         if: github.event_name != 'workflow_dispatch' || inputs.should-run-tests

README.md

@@ -126,6 +126,7 @@ Check out the [contributions guide](https://docs.elementary-data.com/general/con
 <a href="https://github.com/haritamar"><img src="https://github.com/u/11314965?v=4" width="50" height="50" alt=""/></a>
 <a href="https://github.com/Hadarsagiv"><img src="https://github.com/u/119170841?v=4" width="50" height="50" alt=""/></a>
 <a href="https://github.com/RoiTabach"><img src="https://github.com/u/25003091?v=4" width="50" height="50" alt=""/></a>
+<a href="https://github.com/noaKurman"><img src="https://github.com/u/16741969?v=4" width="50" height="50" alt=""/></a>
 <a href="https://github.com/hahnbeelee"><img src="https://github.com/u/55263191?v=4" width="50" height="50" alt=""/></a>
 <a href="https://github.com/seanglynn-thrive"><img src="https://github.com/u/93200565?v=4" width="50" height="50" alt=""/></a>
 <a href="https://github.com/hanywang2"><img src="https://github.com/u/44352119?v=4" width="50" height="50" alt=""/></a>
@@ -170,6 +171,8 @@ Check out the [contributions guide](https://docs.elementary-data.com/general/con
 <a href="https://github.com/Chintanvpatel"><img src="https://github.com/u/1384301?v=4" width="50" height="50" alt=""/></a>
 <a href="https://github.com/andreqaugusto"><img src="https://github.com/u/68784205?v=4" width="50" height="50" alt=""/></a>
 <a href="https://github.com/tc-chrisbui"><img src="https://github.com/u/115048867?v=4" width="50" height="50" alt=""/></a>
+<a href="https://github.com/vishaalkk"><img src="https://github.com/u/13641827?v=4" width="50" height="50" alt=""/></a>
+<a href="https://github.com/sadahry"><img src="https://github.com/u/28292300?v=4" width="50" height="50" alt=""/></a>
 
 <!-- markdownlint-restore -->
 <!-- prettier-ignore-end -->

docs/_snippets/faq/question-singular-tests-config.mdx

@@ -9,8 +9,8 @@ You can add configuration to your custom tests with a config block:
 {{ config(
     tags=["Tag1","Tag2"]
     meta={
-        description: "This is a description",
-        owner: "Maayan Salom"
+        "description": "This is a description",
+        "owner": "Maayan Salom"
     }
 ) }}
 

docs/quickstart/send-slack-alerts.mdx

@@ -432,7 +432,7 @@ Elementary also supports grouping alerts by table. In this case, a single Slack
 To group alerts by table:
 
 ```shell
-edr monitor --group_by table
+edr monitor --group-by table
 ```
 
 Grouping can also be configured through the yml files. To set it up globaly for your project, add the configuration to your models in the dbt_project.yml file:  

docs/understand-elementary/cli-commands.mdx

@@ -62,6 +62,12 @@ Here is a list of all the available options:
   The path of the directory in which your `config.yml` file is located. Default is `HOME_DIR/.edr`.
 
 ```shell
+--target-path <PATH>
+```
+
+- **Configuration target directory path**
+  The absolute path where all output files such as logs and reports will be saved. If not configured, the default is ./edr_target.
+```shell
 -c, --config-dir <PATH>
 ```
 

elementary/cli/cli.py

@@ -1,3 +1,4 @@
+import os
 from typing import Any
 
 import click
@@ -7,9 +8,9 @@
 from elementary.config.config import Config
 from elementary.monitor.cli import monitor, report, send_report
 from elementary.operations.cli import run_operation
-from elementary.tracking.anonymous_tracking import AnonymousTracking
+from elementary.tracking.anonymous_tracking import AnonymousCommandLineTracking
 from elementary.utils import package
-from elementary.utils.log import get_logger
+from elementary.utils.log import get_logger, set_root_logger_handlers
 
 f = Figlet(font="slant")
 click.echo(f.renderText("Elementary"))
@@ -18,6 +19,17 @@
 logger = get_logger(__name__)
 
 
+def get_log_path(ctx):
+    file_path = Config.DEFAULT_FILES_PATH
+    try:
+        ctx_args = ctx.args
+        target_path_flag = "--target-path"
+        file_path = ctx_args[ctx_args.index(target_path_flag) + 1]
+    finally:
+        os.makedirs(os.path.abspath(file_path), exist_ok=True)
+        return os.path.join(file_path, "edr.log")
+
+
 class ElementaryCLI(click.MultiCommand):
     _CMD_MAP = {
         "monitor": monitor,
@@ -36,7 +48,7 @@ def get_command(self, ctx, name):
     def format_help(self, ctx, formatter):
         try:
             click.echo("Loading dependencies (this might take a few seconds)")
-            AnonymousTracking(config=Config()).track_cli_help()
+            AnonymousCommandLineTracking(config=Config()).track_cli_help()
         except Exception:
             pass
         self.format_usage(ctx, formatter)
@@ -45,6 +57,8 @@ def format_help(self, ctx, formatter):
         self.format_epilog(ctx, formatter)
 
     def invoke(self, ctx: click.Context) -> Any:
+        files_target_path = get_log_path(ctx)
+        set_root_logger_handlers("elementary", files_target_path)
         click.echo(
             "Any feedback and suggestions are welcomed! join our community here - "
             "https://bit.ly/slack-elementary\n"

elementary/clients/api/api_client.py

@@ -2,9 +2,6 @@
 from typing import Any
 
 from elementary.clients.dbt.base_dbt_runner import BaseDbtRunner
-from elementary.utils.log import get_logger
-
-logger = get_logger(__name__)
 
 
 class APIClient:

elementary/clients/dbt/slim_dbt_runner.py

@@ -12,7 +12,6 @@
 from dbt.flags import set_from_args
 from dbt.parser.manifest import ManifestLoader
 from dbt.tracking import disable_tracking
-from dbt.version import __version__
 from pydantic import BaseModel, validator
 
 from elementary.clients.dbt.base_dbt_runner import BaseDbtRunner

elementary/clients/gcs/client.py

@@ -8,7 +8,7 @@
 from google.oauth2 import service_account
 
 from elementary.config.config import Config
-from elementary.tracking.anonymous_tracking import AnonymousTracking
+from elementary.tracking.tracking_interface import Tracking
 from elementary.utils import bucket_path
 from elementary.utils.log import get_logger
 
@@ -18,14 +18,14 @@
 
 
 class GCSClient:
-    def __init__(self, config: Config, tracking: AnonymousTracking = None):
+    def __init__(self, config: Config, tracking: Tracking = None):
         self.config = config
         self.client = self.get_client(config)
         self.tracking = tracking
 
     @classmethod
     def create_client(
-        cls, config: Config, tracking: AnonymousTracking = None
+        cls, config: Config, tracking: Tracking = None
     ) -> Optional["GCSClient"]:
         return cls(config, tracking=tracking) if config.has_gcs else None
 

elementary/clients/s3/client.py

@@ -4,15 +4,15 @@
 import boto3
 
 from elementary.config.config import Config
-from elementary.tracking.anonymous_tracking import AnonymousTracking
+from elementary.tracking.tracking_interface import Tracking
 from elementary.utils import bucket_path
 from elementary.utils.log import get_logger
 
 logger = get_logger(__name__)
 
 
 class S3Client:
-    def __init__(self, config: Config, tracking: AnonymousTracking = None):
+    def __init__(self, config: Config, tracking: Tracking = None):
         self.config = config
         aws_session = boto3.Session(
             profile_name=config.aws_profile_name,
@@ -24,7 +24,7 @@ def __init__(self, config: Config, tracking: AnonymousTracking = None):
 
     @classmethod
     def create_client(
-        cls, config: Config, tracking: AnonymousTracking = None
+        cls, config: Config, tracking: Tracking = None
     ) -> Optional["S3Client"]:
         return cls(config, tracking=tracking) if config.has_s3 else None
 

elementary/clients/slack/client.py

@@ -9,7 +9,7 @@
 
 from elementary.clients.slack.schema import SlackMessageSchema
 from elementary.config.config import Config
-from elementary.tracking.anonymous_tracking import AnonymousTracking
+from elementary.tracking.tracking_interface import Tracking
 from elementary.utils.log import get_logger
 
 logger = get_logger(__name__)
@@ -21,7 +21,7 @@
 
 class SlackClient(ABC):
     def __init__(
-        self, token: str = None, webhook: str = None, tracking: AnonymousTracking = None
+        self, token: str = None, webhook: str = None, tracking: Tracking = None
     ) -> None:
         self.token = token
         self.webhook = webhook
@@ -32,7 +32,7 @@ def __init__(
 
     @staticmethod
     def create_client(
-        config: Config, tracking: AnonymousTracking = None
+        config: Config, tracking: Tracking = None
     ) -> Optional["SlackClient"]:
         if not config.has_slack:
             return None
@@ -90,7 +90,7 @@ def send_message(
         except SlackApiError as err:
             if self._handle_send_err(err, channel_name):
                 return self.send_message(channel_name, message)
-            self.tracking.record_cli_internal_exception(err)
+            self.tracking.record_internal_exception(err)
             return False
 
     @sleep_and_retry
@@ -159,8 +159,7 @@ def _join_channel(self, channel_id: str) -> bool:
             return True
         except SlackApiError as e:
             logger.error(f"Elementary app failed to join the given channel. Error: {e}")
-            if self.tracking:
-                self.tracking.record_cli_internal_exception(e)
+            self.tracking.record_internal_exception(e)
             return False
 
     def _handle_send_err(self, err: SlackApiError, channel_name: str) -> bool:

elementary/config/config.py

@@ -31,13 +31,16 @@ class Config:
 
     DEFAULT_CONFIG_DIR = str(Path.home() / ".edr")
 
+    DEFAULT_FILES_PATH = os.getcwd() + "/edr_target"
+
     def __init__(
         self,
         config_dir: str = DEFAULT_CONFIG_DIR,
         profiles_dir: str = None,
         project_dir: str = None,
         profile_target: str = None,
         project_profile_target: str = None,
+        target_path: str = DEFAULT_FILES_PATH,
         dbt_quoting: bool = None,
         update_bucket_website: bool = None,
         slack_webhook: str = None,
@@ -70,9 +73,11 @@ def __init__(
         config = self._load_configuration()
 
         self.target_dir = self._first_not_none(
+            target_path,
             config.get("target-path"),
             os.getcwd(),
         )
+        os.makedirs(os.path.abspath(self.target_dir), exist_ok=True)
 
         self.update_bucket_website = self._first_not_none(
             update_bucket_website,

elementary/exceptions/exceptions.py

@@ -44,6 +44,7 @@ def __init__(
 
         # Command args sent to _run_command (without additional user-specific args it as such as projects / profiles
         # dir)
+        self.proc_err = err
         self.base_command_args = base_command_args
         self.return_code = err.returncode