Skip to content

Allow tracking to be Optional#744

Merged
oravi merged 6 commits intomasterfrom
ele-466-k8s-create-airflow-task-to-send-alerts
Mar 19, 2023
Merged

Allow tracking to be Optional#744
oravi merged 6 commits intomasterfrom
ele-466-k8s-create-airflow-task-to-send-alerts

Conversation

@RoiTabach
Copy link
Copy Markdown
Contributor

No description provided.

This will help when calling those classes from Airflow - we don't pass tracking there and don't have access to MockTracking from elementary/tests
@linear
Copy link
Copy Markdown

linear bot commented Mar 9, 2023

ELE-466 K8s - Create airflow task to send alerts

DAG Steps:

  1. Query the configurations from the DB using the ORM.
  2. For each configuration, run edr monitor against the synced schema from the configuration.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 9, 2023

👋 @RoiTabach
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@elongl
Copy link
Copy Markdown
Contributor

elongl commented Mar 16, 2023

I think a better approach would be to enable the _do_not_track property on the tracking object because it won't require doing if self.tracking whenever we use the tracking.

@oravi oravi merged commit b6201ac into master Mar 19, 2023
@oravi oravi deleted the ele-466-k8s-create-airflow-task-to-send-alerts branch March 19, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants