Enable support for multiple links and icons in alert messages#1927
Merged
MikaKerman merged 4 commits intomasterfrom Jun 3, 2025
Merged
Enable support for multiple links and icons in alert messages#1927MikaKerman merged 4 commits intomasterfrom
MikaKerman merged 4 commits intomasterfrom
Conversation
…port" in various test fixtures and utility functions.
… LinksLineBlock for rendering multiple links with optional icons, and updated AlertMessageBuilder to utilize this new structure.
Contributor
|
👋 @MikaKerman |
ofek1weiss
approved these changes
Jun 3, 2025
|
|
||
| def LinksLineBlock(*, links: list[tuple[str, str, Optional[Icon]]]) -> LineBlock: | ||
| return LineBlock( | ||
| inlines=sum( |
Contributor
There was a problem hiding this comment.
NIT - i realy dont like using sum to flatten a list, you can use itertools.chain.from_iterable or double list comprehension instead
arbiv
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the alert messaging infrastructure to support multiple links and icons, improving the flexibility and functionality of alert notifications.
Changes
🔧 Alert Message Infrastructure Refactor
LinksLineBlockcomponent for rendering multiple links with optional iconsAlertMessageBuilderto utilize the new multi-link structure_get_run_alert_subtitle_links()method