feat(core)!: remove global module templates #4065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikian
approved these changes
Dec 3, 2025
| __dirname, | ||
| '..', | ||
| 'fixture', | ||
| 'global-stub', |
Member
There was a problem hiding this comment.
suggestion: let's delete this fixture folder since it's no longer used.
Member
Author
There was a problem hiding this comment.
I don't think the folder actually exists. IIRC I just had to wire up the mock this way so that npm had something to work with.
Member
There was a problem hiding this comment.
We actually have it in version control: https://github.com/electron/forge/tree/33401e788b1728f3c0f2513bfd2874b8af7ceafd/packages/api/core/spec/fixture/global-stub
Member
Author
There was a problem hiding this comment.
Ah, I think VSCode code search failed me because of node_modules being in the path there. I'll fix that ASAP. 😓
MarshallOfSound
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a thorn on our side for a long, long time.
BREAKING CHANGE: Removes the ability to search for globally installed templates via the
initcommand.