SLO roles privileges changed by eedugon · Pull Request #4300 · elastic/observability-docs

eedugon · 2024-09-25T13:57:30Z

Description

As described at https://github.com/elastic/observability-docs/issues/4229 in 8.16 the SLO permissions have changed, and also the builtin editor role is an option to grant privileges for SLOs.

This PR updates the slo-privileges.asciidoc and its associated images.
It also adds a minor change in serverless doc, as the required role to create SLOs is Editor and not Admin.

Documentation sets edited in this PR

Check all that apply.

Stateful (docs/en/observability/*)
Serverless (docs/en/serverless/*)
Integrations Developer Guide (docs/en/integrations/*)
None of the above

Related issue

Closes https://github.com/elastic/observability-docs/issues/4229

Checklist

Product/Engineering Review
Writer Review

Follow-up tasks

Select one.

This PR does not need to be ported to another doc set because:
- The concepts in this PR only apply to one doc set (serverless or stateful)
- The PR contains edits to both doc sets (serverless and stateful)
This PR needs to be ported to another doc set:
- Port to stateful docs: <link to PR or tracking issue>
- Port to serverless docs: <link to PR or tracking issue>

github-actions · 2024-09-25T13:57:44Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

mergify · 2024-09-25T13:58:10Z

This pull request does not have a backport label. Could you fix it @eedugon? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
NOTE: backport-skip has been added to this pull request.

eedugon · 2024-09-26T10:30:48Z

Thanks @bmorelli25 for your comments and suggestions here!

dominiqueclarke

LGTM

…s_816

alaudazzi

I left a few minor editing suggestions, otherwise LGTM.

Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>

change see by check Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>

eedugon · 2024-10-14T09:21:10Z

 import Roles from '../partials/roles.mdx'

-<Roles role="Admin" goal="create SLOs" />
+<Roles role="Editor" goal="create SLOs" />


@dominiqueclarke : I have updated the serverless doc as mentioned in https://github.com/elastic/observability-docs/issues/4229

alaudazzi

LGTM

* SLO roles privileges changed to match 8.16 release * editor builtin role information added * wording and order of privileges options changed * minor wording changes * serverless required role updated * rephrasing permissions Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> * removing future tense Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> * Update docs/en/observability/slo-privileges.asciidoc change see by check Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> --------- Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> (cherry picked from commit bb910be) # Conflicts: # docs/en/serverless/slos/create-an-slo.mdx

* SLO roles privileges changed (#4300) * SLO roles privileges changed to match 8.16 release * editor builtin role information added * wording and order of privileges options changed * minor wording changes * serverless required role updated * rephrasing permissions Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> * removing future tense Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> * Update docs/en/observability/slo-privileges.asciidoc change see by check Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> --------- Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> (cherry picked from commit bb910be) # Conflicts: # docs/en/serverless/slos/create-an-slo.mdx * Delete docs/en/serverless directory --------- Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

eedugon · 2024-11-07T08:49:08Z

quick question here @alaudazzi and @bmorelli25 : do we need a backport to 8.16 here or was this unneeded at that time?

eedugon · 2024-11-07T09:03:14Z

I think it does, I don't find the commit of this PR in 8.16 and I'm able to find it in main and 8.x.... creating the backport now...

* SLO roles privileges changed to match 8.16 release * editor builtin role information added * wording and order of privileges options changed * minor wording changes * serverless required role updated * rephrasing permissions Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> * removing future tense Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> * Update docs/en/observability/slo-privileges.asciidoc change see by check Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> --------- Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> (cherry picked from commit bb910be) # Conflicts: # docs/en/serverless/slos/create-an-slo.mdx

* SLO roles privileges changed (#4300) * SLO roles privileges changed to match 8.16 release * editor builtin role information added * wording and order of privileges options changed * minor wording changes * serverless required role updated * rephrasing permissions Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> * removing future tense Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> * Update docs/en/observability/slo-privileges.asciidoc change see by check Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> --------- Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com> (cherry picked from commit bb910be) # Conflicts: # docs/en/serverless/slos/create-an-slo.mdx * Delete docs/en/serverless directory --------- Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

SLO roles privileges changed

bd9af71

eedugon requested a review from a team as a code owner September 25, 2024 13:57

docs-project-automation Bot added the needs-writer-review label Sep 25, 2024

mergify Bot added the backport-skip Skip notification from the automated backport with mergify label Sep 25, 2024

eedugon added 3 commits September 25, 2024 16:52

editor builtin role information added

f763039

wording and order of privileges options changed

55a0a4b

minor wording changes

9e65c1a

eedugon changed the title ~~[WIP] SLO roles privileges changed~~ SLO roles privileges changed Sep 26, 2024

eedugon requested a review from dominiqueclarke October 8, 2024 12:09

dominiqueclarke previously approved these changes Oct 9, 2024

View reviewed changes

eedugon added 2 commits October 14, 2024 11:15

Merge remote-tracking branch 'origin/main' into eedugon/slo_privilege…

bbc630d

…s_816

serverless required role updated

0340dc6

eedugon dismissed dominiqueclarke’s stale review via 0340dc6 October 14, 2024 09:20

alaudazzi previously approved these changes Oct 14, 2024

View reviewed changes

Comment thread docs/en/observability/slo-privileges.asciidoc Outdated

Comment thread docs/en/observability/slo-privileges.asciidoc

Comment thread docs/en/observability/slo-privileges.asciidoc Outdated

rephrasing permissions

94ee96f

Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>

eedugon dismissed alaudazzi’s stale review via 94ee96f October 14, 2024 11:31

eedugon and others added 2 commits October 14, 2024 13:31

removing future tense

bd15efb

Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>

Update docs/en/observability/slo-privileges.asciidoc

5a70180

change see by check Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>

eedugon commented Oct 15, 2024

View reviewed changes

alaudazzi approved these changes Oct 15, 2024

View reviewed changes

eedugon added backport-8.x Automated backport to the 8.x branch with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Oct 16, 2024

eedugon merged commit bb910be into elastic:main Oct 16, 2024

eedugon deleted the eedugon/slo_privileges_816 branch October 16, 2024 16:15

mergify Bot mentioned this pull request Oct 16, 2024

[8.x](backport #4300) SLO roles privileges changed #4382

Merged

10 tasks

eedugon removed the needs-writer-review label Oct 16, 2024

eedugon added the backport-8.16 Automated backport with mergify label Nov 7, 2024

mergify Bot mentioned this pull request Nov 7, 2024

[8.16](backport #4300) SLO roles privileges changed #4498

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

SLO roles privileges changed#4300

SLO roles privileges changed#4300
eedugon merged 9 commits into
elastic:mainfrom
eedugon:eedugon/slo_privileges_816

eedugon commented Sep 25, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 25, 2024

Uh oh!

mergify Bot commented Sep 25, 2024

Uh oh!

eedugon commented Sep 26, 2024

Uh oh!

dominiqueclarke left a comment

Uh oh!

alaudazzi left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eedugon Oct 14, 2024

Uh oh!

alaudazzi left a comment

Uh oh!

eedugon commented Nov 7, 2024

Uh oh!

eedugon commented Nov 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

eedugon commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Documentation sets edited in this PR

Related issue

Checklist

Follow-up tasks

Uh oh!

github-actions Bot commented Sep 25, 2024

Uh oh!

mergify Bot commented Sep 25, 2024

Uh oh!

eedugon commented Sep 26, 2024

Uh oh!

dominiqueclarke left a comment

Choose a reason for hiding this comment

Uh oh!

alaudazzi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eedugon Oct 14, 2024

Choose a reason for hiding this comment

Uh oh!

alaudazzi left a comment

Choose a reason for hiding this comment

Uh oh!

eedugon commented Nov 7, 2024

Uh oh!

eedugon commented Nov 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

eedugon commented Sep 25, 2024 •

edited

Loading