Skip to content

[APM] Add note about @custom component templates#4200

Merged
colleenmcginnis merged 5 commits into
elastic:mainfrom
colleenmcginnis:issue-apm-server-11651
Oct 9, 2024
Merged

[APM] Add note about @custom component templates#4200
colleenmcginnis merged 5 commits into
elastic:mainfrom
colleenmcginnis:issue-apm-server-11651

Conversation

@colleenmcginnis

@colleenmcginnis colleenmcginnis commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

Fixes elastic/apm-server#11651

👋 @marclop it's not clear in the issue if this applies only to [data_stream][dataset] or also to type and namespace, too.

@colleenmcginnis colleenmcginnis added backport-8.14 Automated backport with mergify backport-8.15 Automated backport with mergify labels Aug 26, 2024
@colleenmcginnis colleenmcginnis self-assigned this Aug 26, 2024
@github-actions

github-actions Bot commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@bmorelli25 bmorelli25 added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 12, 2024
@colleenmcginnis

colleenmcginnis commented Sep 16, 2024

Copy link
Copy Markdown
Contributor Author

👋 @marclop can you take a look at this PR sometime this week?

marclop
marclop reviewed Sep 18, 2024
View reviewed changes
Comment thread docs/en/observability/apm/configure/outputs/logstash.asciidoc Outdated
@colleenmcginnis colleenmcginnis requested a review from axw September 20, 2024 17:12
@colleenmcginnis colleenmcginnis marked this pull request as ready for review September 23, 2024 13:55
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner September 23, 2024 13:55
mdbirnstiehl
mdbirnstiehl previously approved these changes Sep 23, 2024
View reviewed changes

@mdbirnstiehl mdbirnstiehl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦

colleenmcginnis
colleenmcginnis commented Sep 26, 2024
View reviewed changes

@colleenmcginnis colleenmcginnis left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your input @axw @marclop! I attempted to capture your feedback in the latest commit, and I left some specific questions below. Here's the preview: Accessing the @metadata field.

Comment thread docs/en/observability/apm/configure/outputs/logstash.asciidoc Outdated
Comment thread docs/en/observability/apm/configure/outputs/logstash.asciidoc Outdated
Comment thread docs/en/observability/apm/configure/outputs/logstash.asciidoc
axw
axw reviewed Oct 8, 2024
View reviewed changes
Comment thread docs/en/observability/apm/configure/outputs/logstash.asciidoc Outdated
Comment thread docs/en/observability/apm/configure/outputs/logstash.asciidoc
Comment thread docs/en/observability/apm/configure/outputs/logstash.asciidoc Outdated
Comment thread docs/en/observability/apm/configure/outputs/logstash.asciidoc Outdated
@colleenmcginnis colleenmcginnis requested a review from axw October 8, 2024 13:40
axw
axw approved these changes Oct 9, 2024
View reviewed changes

@axw axw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @colleenmcginnis!

mdbirnstiehl
mdbirnstiehl approved these changes Oct 9, 2024
View reviewed changes

@mdbirnstiehl mdbirnstiehl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭 👍

@colleenmcginnis colleenmcginnis merged commit 15dde46 into elastic:main Oct 9, 2024
mergify Bot pushed a commit that referenced this pull request Oct 9, 2024
@mergify
[APM] Add note about @custom component templates (#4200)
faa6a0e 
* add note about custom component templates

* attempt to address feedback

* apply suggestions from @axw

(cherry picked from commit 15dde46)
@mergify mergify Bot mentioned this pull request Oct 9, 2024
Merged
mergify Bot pushed a commit that referenced this pull request Oct 9, 2024
@mergify
[APM] Add note about @custom component templates (#4200)
7cb2086 
* add note about custom component templates

* attempt to address feedback

* apply suggestions from @axw

(cherry picked from commit 15dde46)
@mergify mergify Bot mentioned this pull request Oct 9, 2024
Merged
mergify Bot pushed a commit that referenced this pull request Oct 9, 2024
@mergify
[APM] Add note about @custom component templates (#4200)
bf2aa91 
* add note about custom component templates

* attempt to address feedback

* apply suggestions from @axw

(cherry picked from commit 15dde46)
@mergify mergify Bot mentioned this pull request Oct 9, 2024
Merged
@colleenmcginnis colleenmcginnis deleted the issue-apm-server-11651 branch October 9, 2024 21:13
colleenmcginnis pushed a commit that referenced this pull request Oct 9, 2024
@mergify
[APM] Add note about @custom component templates (#4200) (#4365)
8ad19b1 
* add note about custom component templates

* attempt to address feedback

* apply suggestions from @axw

(cherry picked from commit 15dde46)

Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co>
colleenmcginnis pushed a commit that referenced this pull request Oct 9, 2024
@mergify
[APM] Add note about @custom component templates (#4200) (#4364)
7b70d5b 
* add note about custom component templates

* attempt to address feedback

* apply suggestions from @axw

(cherry picked from commit 15dde46)

Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co>
colleenmcginnis pushed a commit that referenced this pull request Oct 9, 2024
@mergify
[APM] Add note about @custom component templates (#4200) (#4363)
81d0e24 
* add note about custom component templates

* attempt to address feedback

* apply suggestions from @axw

(cherry picked from commit 15dde46)

Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@axw axw axw approved these changes
@mdbirnstiehl mdbirnstiehl mdbirnstiehl approved these changes
@marclop marclop Awaiting requested review from marclop

Assignees

@colleenmcginnis colleenmcginnis

Labels

backport-8.x Automated backport to the 8.x branch with mergify backport-8.14 Automated backport with mergify backport-8.15 Automated backport with mergify needs-writer-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Configure Logstash output has an non-working example due to a constant_keyword field

5 participants

@colleenmcginnis @axw @marclop @mdbirnstiehl @bmorelli25