Skip to content

httpjson: remove leftover single quote#4727

Merged
efd6 merged 2 commits into
elastic:mainfrom
efd6:httpjson-doc
Dec 1, 2022
Merged

httpjson: remove leftover single quote#4727
efd6 merged 2 commits into
elastic:mainfrom
efd6:httpjson-doc

Conversation

@efd6

@efd6 efd6 commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Minor clean-up to the docs page. Probably not worth a version bump; will be picked up with the next significant change.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:httpjson Custom API labels Nov 29, 2022
@efd6 efd6 self-assigned this Nov 29, 2022
@efd6 efd6 requested a review from a team as a code owner November 29, 2022 05:38
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented Nov 29, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-01T21:32:17.338+0000

  • Duration: 16 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Nov 29, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.265
Classes 100.0% (0/0) 💚 2.265
Methods 100.0% (3/3) 💚 8.709
Lines 100.0% (0/0) 💚 7.986
Conditionals 100.0% (0/0) 💚

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 Just need a minor clarification.

Should we have changelog.yml entry for this minor change?

@efd6

efd6 commented Dec 1, 2022

Copy link
Copy Markdown
Contributor Author

Yeah, I'm not sure about that. It's in the process design, but I haven't seen it done before.

@efd6 efd6 merged commit 3ff42ba into elastic:main Dec 1, 2022
@elasticmachine

Copy link
Copy Markdown

Package httpjson - 1.6.1 containing this change is available at https://epr.elastic.co/search?package=httpjson

@efd6 efd6 deleted the httpjson-doc branch February 5, 2025 22:06
@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 1, 2025
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:httpjson Custom API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants