Skip to content

Add GCS input to Cloudflare Logpush#4720

Merged
ShourieG merged 10 commits into
elastic:mainfrom
ShourieG:gcs/package-updates
Dec 1, 2022
Merged

Add GCS input to Cloudflare Logpush#4720
ShourieG merged 10 commits into
elastic:mainfrom
ShourieG:gcs/package-updates

Conversation

@ShourieG

@ShourieG ShourieG commented Nov 28, 2022

Copy link
Copy Markdown
Contributor

Type of change

  • Enhancement

What does this PR do?

Adds support for GCS input to the Cloudflare Logpush package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Screenshot 2022-11-28 at 1 09 39 PM

@ShourieG ShourieG requested a review from a team as a code owner November 28, 2022 07:40
@elasticmachine

elasticmachine commented Nov 28, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-30T09:34:56.588+0000

  • Duration: 19 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 44
Skipped 0
Total 44

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ShourieG ShourieG requested a review from efd6 November 28, 2022 08:03
@elasticmachine

elasticmachine commented Nov 28, 2022

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

elasticmachine commented Nov 28, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (7/7) 💚
Files 100.0% (7/7) 💚
Classes 100.0% (7/7) 💚
Methods 100.0% (89/89) 💚
Lines 94.37% (2380/2522) 👎 -1.902
Conditionals 100.0% (0/0) 💚

@ShourieG ShourieG requested a review from P1llus November 28, 2022 08:20
efd6
efd6 reviewed Nov 29, 2022
View reviewed changes
Comment thread packages/cloudflare_logpush/_dev/build/docs/README.md Outdated
Comment thread packages/cloudflare_logpush/_dev/build/docs/README.md Outdated
Comment thread packages/cloudflare_logpush/data_stream/audit/manifest.yml Outdated
@ShourieG ShourieG self-assigned this Nov 29, 2022
@ShourieG

ShourieG commented Nov 30, 2022

Copy link
Copy Markdown
Contributor Author

@efd6 have updated the PR

efd6
efd6 approved these changes Nov 30, 2022
View reviewed changes

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after minor change.

Comment thread packages/cloudflare_logpush/manifest.yml Outdated
Comment thread packages/cloudflare_logpush/manifest.yml Outdated
Comment thread packages/cloudflare_logpush/manifest.yml Outdated
Comment thread packages/cloudflare_logpush/manifest.yml Outdated
@ShourieG ShourieG merged commit 941348f into elastic:main Dec 1, 2022
@jamiehynds

jamiehynds commented Dec 1, 2022

Copy link
Copy Markdown

Thanks @ShourieG - a few users waiting on this one and very excited to start testing out GCS with Logpush.

@elasticmachine

elasticmachine commented Dec 1, 2022

Copy link
Copy Markdown

Package cloudflare_logpush - 0.4.0 containing this change is available at https://epr.elastic.co/search?package=cloudflare_logpush

@ShourieG ShourieG deleted the gcs/package-updates branch February 7, 2025 08:53
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@ShourieG
Add GCS input to Cloudflare Logpush (elastic#4720)
64e6c37 
* initial commit to add gcs input to cloudflare_logpush

* updated changelog

* updated manifest with version

* updated docs

* updated docs

* updated docs

* updated docs as per pr suggetions

* updated docs

* updated PR with config changes & suggetions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes
@P1llus P1llus Awaiting requested review from P1llus

Assignees

@ShourieG ShourieG

Labels

8.6 candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ShourieG @elasticmachine @jamiehynds @efd6