Skip to content

[Citrix ADC] Add Integration Package with Interface Data Stream #4322

Merged
kush-elastic merged 7 commits into
elastic:mainfrom
harnish-crest:package_citrix_adc_interface
Nov 9, 2022
Merged

[Citrix ADC] Add Integration Package with Interface Data Stream #4322
kush-elastic merged 7 commits into
elastic:mainfrom
harnish-crest:package_citrix_adc_interface

Conversation

@harnish-crest

@harnish-crest harnish-crest commented Sep 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Enhancement

What does this PR do?

  • Added 1 data stream (Interface metrics).
  • Added data collection logic for the data streams.
  • Added the ingest pipeline for the data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yaml files.
  • Added dashboards and visualizations.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/citrix_adc) directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

Screenshots

citrix_adc-overview-dashboard
new-interface-dashboard

@harnish-crest harnish-crest marked this pull request as draft September 27, 2022 13:10
@elasticmachine

elasticmachine commented Sep 27, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-02T11:23:14.046+0000

  • Duration: 16 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@yug-rajani

yug-rajani commented Sep 27, 2022

Copy link
Copy Markdown
Contributor

/test

1 similar comment
@kush-elastic

kush-elastic commented Sep 27, 2022

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

elasticmachine commented Sep 27, 2022

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

elasticmachine commented Sep 27, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.703
Classes 100.0% (1/1) 💚 2.703
Methods 100.0% (9/9) 💚 9.14
Lines 98.047% (251/256) 👍 6.459
Conditionals 100.0% (0/0) 💚

@harnish-crest harnish-crest marked this pull request as ready for review September 28, 2022 04:52
@yug-rajani yug-rajani added enhancement New feature or request Integration:Citrix-Netscaler Team:Service-Integrations Label for the Observability Service Integrations team labels Sep 28, 2022
@yug-rajani yug-rajani linked an issue Sep 28, 2022 that may be closed by this pull request
Create package to monitor server workers using Citrix ADC (Netscaler) #3746
Closed
5 tasks
@muthu-mps muthu-mps self-requested a review September 28, 2022 10:49
This was referenced Oct 3, 2022
Merged
Merged
@muthu-mps

muthu-mps commented Oct 10, 2022

Copy link
Copy Markdown
Contributor

Please remove ibmmq in the How to test this PR instructions

muthu-mps
muthu-mps reviewed Oct 10, 2022
View reviewed changes
Comment thread packages/citrix_adc/_dev/build/docs/README.md Outdated
Comment thread packages/citrix_adc/data_stream/interface/elasticsearch/ingest_pipeline/default.yml
@harnish-crest harnish-crest requested review from muthu-mps and removed request for lalit-satapathy October 12, 2022 05:50
@harnish-crest harnish-crest mentioned this pull request Oct 13, 2022
Merged
4 tasks
muthu-mps
muthu-mps reviewed Oct 17, 2022
View reviewed changes
Comment thread packages/citrix_adc/data_stream/interface/fields/fields.yml
Comment thread packages/citrix_adc/_dev/build/docs/README.md Outdated
Comment thread packages/citrix_adc/data_stream/interface/_dev/test/pipeline/test-interface-metrics.log
@muthu-mps

muthu-mps commented Oct 17, 2022

Copy link
Copy Markdown
Contributor

Can we add new visualisation's that would show the received, transmitted bytes and dropped inbound, outbound packets over the period of time ?

@harnish-crest harnish-crest mentioned this pull request Oct 19, 2022
Merged
4 tasks
@muthu-mps

muthu-mps commented Oct 31, 2022

Copy link
Copy Markdown
Contributor

Can we remove the Value of from the visualisation names for Received and Transmitted Bytes ?

@harnish-crest

harnish-crest commented Nov 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Can we remove the Value of from the visualisation names for Received and Transmitted Bytes ?

Makes sense. We will be removing number of and value of from the titles of all the visualization, and following will be updated titles for all the visualizations,

  • Outbound Packets Dropped by Hardware over time
  • Inbound Packets Dropped over time
  • Received Bytes over time
  • Transmitted Bytes over time

Please let me know if there are any other changes related to dashboard which needs to be updated, so we can reduce this back and forth.

@muthu-mps

muthu-mps commented Nov 1, 2022

Copy link
Copy Markdown
Contributor

Can we remove the Value of from the visualisation names for Received and Transmitted Bytes ?

Makes sense. We will be removing number of and value of from the titles of all the visualization, and following will be updated titles for all the visualizations,

  • Outbound Packets Dropped by Hardware over time
  • Inbound Packets Dropped over time
  • Received Bytes over time
  • Transmitted Bytes over time

Please let me know if there are any other changes related to dashboard which needs to be updated, so we can reduce this back and forth.

@harnish-crest - I would recommend to check the visualisation names with other visualisations as well.

@kush-elastic kush-elastic merged commit fac0d29 into elastic:main Nov 9, 2022
@muthu-mps muthu-mps mentioned this pull request Nov 11, 2022
Closed
5 tasks
@andrewkroh andrewkroh added Integration:citrix_adc Citrix ADC New Integration Issue or pull request for creating a new integration package. labels Aug 13, 2024
@zmoog zmoog mentioned this pull request Mar 10, 2025
Merged
5 tasks
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@harnish-crest
[Citrix ADC] Add Integration Package with Interface Data Stream (elas…
a85bb9e 
…tic#4322)

* Add Citrix ADC package with interface data stream

* update changelog entry in changelog.yml

* update format version to 2.0.0, provided tooltip and update pipeline

* minor change in README.md

* add and update dashboards

* minor changes in README.md

* update titles and labels of visualizations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@yug-rajani yug-rajani yug-rajani approved these changes
@muthu-mps muthu-mps muthu-mps approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@harnish-crest harnish-crest

Labels

enhancement New feature or request Integration:citrix_adc Citrix ADC New Integration Issue or pull request for creating a new integration package. Team:Service-Integrations Label for the Observability Service Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create package to monitor server workers using Citrix ADC (Netscaler)

6 participants

@harnish-crest @elasticmachine @yug-rajani @kush-elastic @muthu-mps @andrewkroh