carbon_black_cloud,sentinel_one: ensure consistent ordering of arrays - #4296
Merged
Conversation
efd6
force-pushed
the
setorder
branch
2 times, most recently
from
September 26, 2022 02:09
f56b933 to
52e8c85
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
asset_vulnerability_summary |
9615.38 | 7874.02 | -1741.36 (-18.11%) | 💔 |
To see the full report comment with /test benchmark fullreport
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There has been a change in behaviour in the set iteration order between v8.3.3 and v8.4.1, so sort the array to ensure a stable order for testing. In carbon_black the multiple argument appends with allow_duplicates=false also leads to a change in array ordering. The cause for this is less clear, but sort the array to work around the issue.
Contributor
Author
|
/test |
P1llus
approved these changes
Sep 26, 2022
This was referenced Sep 29, 2022
4 tasks
orestisfl
pushed a commit
to orestisfl/integrations
that referenced
this pull request
May 15, 2026
…elastic#4296) There has been a change in behaviour in the set iteration order between v8.3.3 and v8.4.1, so sort the array to ensure a stable order for testing. In carbon_black the multiple argument appends with allow_duplicates=false also leads to a change in array ordering. The cause for this is less clear, but sort the array to work around the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been a change in behaviour in the set iteration order between v8.3.3 and v8.4.1, so sort the array to ensure a stable order for testing.
In carbon_black the multiple argument appends with allow_duplicates=false also leads to a change in array ordering. The cause for this is less clear, but sort the array to work around the issue.
What does this PR do?
This ensures that arrays which showed unstable ordering between v8.3.3 and v8.4.1 are consistently ordered explicitly.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots