Skip to content

[couchbase] Add Integration Package with Bucket Data Stream#3666

Merged
yug-rajani merged 10 commits into
elastic:mainfrom
bhagyaraj-crest:package_couchbase_bucket
Jul 27, 2022
Merged

[couchbase] Add Integration Package with Bucket Data Stream#3666
yug-rajani merged 10 commits into
elastic:mainfrom
bhagyaraj-crest:package_couchbase_bucket

Conversation

@bhagyaraj-crest

@bhagyaraj-crest bhagyaraj-crest commented Jul 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Enhancement

What does this PR do?

  • Generated the skeleton of Couchbase integration package.
  • Added 1 data stream ( bucket )
  • Added data collection logic.
  • Added the ingest pipelines.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files.
  • Added system test cases.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/couchbase directory.
  • Run the following command to run tests.

elastic-package test

ss1
ss2

@bhagyaraj-crest bhagyaraj-crest changed the title [oracle_weblogic] Add Integration Package with Bucket Data Stream [couchbase] Add Integration Package with Bucket Data Stream Jul 8, 2022
@yug-rajani

yug-rajani commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

elasticmachine commented Jul 8, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-26T18:54:07.617+0000

  • Duration: 25 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 6
Skipped 0
Total 6

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@yug-rajani

yug-rajani commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

elasticmachine commented Jul 8, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.924
Classes 100.0% (1/1) 💚 2.924
Methods 100.0% (7/7) 💚 10.801
Lines 100.0% (89/89) 💚 8.976
Conditionals 100.0% (0/0) 💚

@bhagyaraj-crest bhagyaraj-crest marked this pull request as ready for review July 8, 2022 09:35
@yug-rajani yug-rajani added enhancement New feature or request Integration:couchbase Couchbase Team:Service-Integrations Label for the Observability Service Integrations team labels Jul 8, 2022
@yug-rajani yug-rajani linked an issue Jul 8, 2022 that may be closed by this pull request
Create Couchbase package #613
Closed
8 tasks
yug-rajani
yug-rajani approved these changes Jul 11, 2022
View reviewed changes

@yug-rajani yug-rajani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lalit-satapathy lalit-satapathy requested a review from ritalwar July 14, 2022 08:13
@yug-rajani yug-rajani mentioned this pull request Jul 15, 2022
Merged
4 tasks
@yug-rajani

yug-rajani commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

/test

@jonahbull

jonahbull commented Jul 18, 2022

Copy link
Copy Markdown
Member

cla/check

@bhagyaraj-crest bhagyaraj-crest mentioned this pull request Jul 20, 2022
Merged
4 tasks
ritalwar
ritalwar suggested changes Jul 21, 2022
View reviewed changes

@ritalwar ritalwar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-check and confirm the couchbase logo that is being used.
Also, I don't see any dashboards for this integration.

Comment thread packages/couchbase/manifest.yml
Comment thread packages/couchbase/manifest.yml
Comment thread packages/couchbase/data_stream/bucket/manifest.yml Outdated
Comment thread packages/couchbase/data_stream/bucket/manifest.yml Outdated
Comment thread packages/couchbase/data_stream/bucket/manifest.yml
Comment thread packages/couchbase/data_stream/bucket/fields/fields.yml Outdated
Comment thread packages/couchbase/data_stream/bucket/fields/fields.yml
Comment thread packages/couchbase/data_stream/bucket/sample_event.json Outdated
Comment thread packages/couchbase/data_stream/bucket/elasticsearch/ingest_pipeline/default.yml
Comment thread packages/couchbase/data_stream/bucket/elasticsearch/ingest_pipeline/default.yml
@bhagyaraj-crest

bhagyaraj-crest commented Jul 22, 2022

Copy link
Copy Markdown
Contributor Author

Please re-check and confirm the couchbase logo that is being used.

Other option is to use the following logo:
https://worldvectorlogo.com/logo/couchbase
If you have any other link to a logo, kindly share and we can update it.

Also, I don't see any dashboards for this integration.

Kindly refer the discussion here: #3706 (comment)

@bhagyaraj-crest bhagyaraj-crest requested a review from ritalwar July 22, 2022 10:54
@ritalwar

ritalwar commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

https://worldvectorlogo.com/logo/couchbase

Yes, let's go with this one.

@bhagyaraj-crest

bhagyaraj-crest commented Jul 26, 2022

Copy link
Copy Markdown
Contributor Author

https://worldvectorlogo.com/logo/couchbase

Yes, let's go with this one.

Sure, thanks for the confirmation. Updated the PR with the changes. Kindly perform a final round of review and let us know if you have any further concerns.

ritalwar
ritalwar approved these changes Jul 27, 2022
View reviewed changes

@ritalwar ritalwar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yug-rajani yug-rajani merged commit fc1133d into elastic:main Jul 27, 2022
This was referenced Aug 3, 2022
Merged
Merged
This was referenced Aug 10, 2022
Merged
Merged
This was referenced Aug 18, 2022
Closed
Merged
This was referenced Aug 26, 2022
Merged
Merged
@kush-elastic kush-elastic mentioned this pull request Sep 8, 2022
Merged
4 tasks
@yug-rajani yug-rajani mentioned this pull request Sep 14, 2022
Merged
4 tasks
@kush-elastic kush-elastic mentioned this pull request Nov 1, 2022
Merged
4 tasks
@andrewkroh andrewkroh added the New Integration Issue or pull request for creating a new integration package. label Aug 13, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@bhagyaraj-crest
[couchbase] Add Integration Package with Bucket Data Stream (elastic#…
b2df213 
…3666)

* Add Couchbase integration with Bucket data stream

* Update changelog entry

* Update Kibana constraint version to 8.3.0 and add meta fields in fields.yml

* Nits

* Add Metadata fields

* Update stream.yml.hbs

* Resolve Review comments

* Update details in README and Couchbase logo

* Add a note to README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy
2 more reviewers
@yug-rajani yug-rajani yug-rajani approved these changes
@ritalwar ritalwar ritalwar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@bhagyaraj-crest bhagyaraj-crest

Labels

enhancement New feature or request Integration:couchbase Couchbase New Integration Issue or pull request for creating a new integration package. Team:Service-Integrations Label for the Observability Service Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create Couchbase package

6 participants

@bhagyaraj-crest @yug-rajani @elasticmachine @jonahbull @ritalwar @andrewkroh