AWS Firehose improve integration documentation#12732
Merged
Kavindu-Dodan merged 8 commits intoFeb 14, 2025
Merged
Conversation
Contributor
Author
|
Will conflict with #12687 |
🚀 Benchmarks reportTo see the full report comment with |
16d05c5 to
6708b87
Compare
b5761b3 to
6ea7bfa
Compare
9 tasks
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> # Conflicts: # packages/awsfirehose/changelog.yml # packages/awsfirehose/manifest.yml
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
6885354 to
6175506
Compare
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
vigneshshanmugam
approved these changes
Feb 13, 2025
Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
Contributor
|
Nicely done!!!!
Nit: There is a comma missing (can not make a comment as this part not updated) Idea: So mainly we send Cloudwatch or S3 logs to Firehose. |
gizas
approved these changes
Feb 14, 2025
Contributor
Author
|
@gizas Ahh thanks, fixed with commit 9398c30
There're also improvements to Elastic Documentation 1 which provide detailed guides. Besides, there are multiple ways a Firehose stream could get its data. For example, CloudTrail logs can be ingested through Firehose 2. So we can't simply add a single reference here. However, we can do a follow-up PR once documentation changes ready to link Elastic Documentation into the integration. Footnotes |
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
|
💚 Build Succeeded
History
|
|
Package awsfirehose - 1.5.1 containing this change is available at https://epr.elastic.co/package/awsfirehose/1.5.1/ |
Kavindu-Dodan
added a commit
to elastic/docs-content
that referenced
this pull request
Feb 28, 2025
## Description Improves AWS Firehose documentation, aligning with the update done on AWS Firehose Integration documentation at elastic/integrations#12732 This is a follow-up of elastic/observability-docs#4818 for the new doc content repository. ### Related issue Related PR - elastic/observability-docs#4818 Related : elastic/integrations#12150 Related : elastic/observability-docs#4784 --------- Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
flexitrev
pushed a commit
that referenced
this pull request
Mar 20, 2025
* improve aws firehose integration documentation Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> # Conflicts: # packages/awsfirehose/changelog.yml # packages/awsfirehose/manifest.yml * review changes Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * improve documentation Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * add recommendation on s3 backups Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * Update packages/awsfirehose/_dev/build/docs/README.md Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com> * Update packages/awsfirehose/docs/README.md Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com> * minor fix Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * update doc with minor fix Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> --------- Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Improves the documentation of the AWS Firehose integration.
Checklist
changelog.ymlfile.Related issues