Skip to content

elasticotel: load resource detector as last#532

Open
xrmx wants to merge 3 commits into
mainfrom
move-otel-resource-detector-to-last
Open

elasticotel: load resource detector as last#532
xrmx wants to merge 3 commits into
mainfrom
move-otel-resource-detector-to-last

Conversation

@xrmx

@xrmx xrmx commented Apr 17, 2026

Copy link
Copy Markdown
Member

What does this pull request do?

Since OTel SDK 1.42.0 the order of the resource detectors is preserved. Move the otel resource detector as last so we can override other resource detector attributes from environment variables.

Related issues

Since OTel SDK 1.42.0 the order of the resource detectors is preserved.
Move the otel resource detector as last so we can override other
resource detector attributes from environment variables.
@github-actions

github-actions Bot commented Apr 17, 2026

Copy link
Copy Markdown

🔍 Preview links for changed docs

@github-actions

github-actions Bot commented Apr 17, 2026

Copy link
Copy Markdown

✅ Elastic Docs Style Checker (Vale)

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

Comment thread src/elasticotel/distro/__init__.py Outdated
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
@xrmx xrmx marked this pull request as ready for review June 26, 2026 07:45
@xrmx xrmx requested review from a team as code owners June 26, 2026 07:45
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: a08c4b9e-b5e2-4865-8afc-3e79019c57cd

📥 Commits

Reviewing files that changed from the base of the PR and between 7a17ce4 and f546aa2.

📒 Files selected for processing (4)
  • docs/reference/edot-python/configuration.md
  • src/elasticotel/distro/__init__.py
  • tests/distro/test_distro.py
  • tests/integration/test_integration.py

📝 Walkthrough

Walkthrough

ElasticOpenTelemetryDistro._configure now appends otel after the cloud resource detectors so it runs last. The default configuration test and configuration reference were updated to match the detector ordering. A new integration test verifies that OTEL_RESOURCE_ATTRIBUTES can override telemetry.distro.name in emitted span resources.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch move-otel-resource-detector-to-last
  • 🛠️ Update Documentation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants