Skip to content

feat: release process#145

Merged
SylvainJuge merged 11 commits into
mainfrom
feat/release-process
Feb 23, 2024
Merged

feat: release process#145
SylvainJuge merged 11 commits into
mainfrom
feat/release-process

Conversation

@amannocci

@amannocci amannocci commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

What is the change being made?

  • Implement full release process.

Why is the change being made?

  • Add the ability to release a new version without lifting branch protections.

Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
Comment thread .github/workflows/release.yml Outdated
Comment thread build.gradle Outdated
Comment thread .github/workflows/release.yml
Comment thread .github/workflows/pre-post-release.yml
Comment thread .github/workflows/gradle-goal/action.yml
Comment thread .github/workflows/release.yml
Comment thread build.gradle Outdated
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci amannocci marked this pull request as ready for review February 23, 2024 10:51
@amannocci amannocci changed the title WIP feat: release process feat: release process Feb 23, 2024

@v1v v1v left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be another follow-up with the changes in

### TODO: changeme
publishArg='assemble'
, won't it?

Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml
Comment thread .github/workflows/snapshot.yml Outdated
Comment thread .github/workflows/pre-post-release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>

@v1v v1v left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @amannocci for this! 💯

As I mentioned in a previous comment,

### TODO: changeme
publishArg='assemble'
will need to be accommodated to run the release.

In a follow-up, so we play safe?

@SylvainJuge, what's the required target goal? The same as

publishArg='publishToSonatype closeAndReleaseStagingRepository'
?

@SylvainJuge

Copy link
Copy Markdown
Member

@SylvainJuge, what's the required target goal? The same as

publishArg='publishToSonatype closeAndReleaseStagingRepository'

?

It's the same as the snapshot, so:

 publishArg='publishToSonatype closeAndReleaseStagingRepository'

When run with a non-snapshot version it should publish to the releases repository.

Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci

amannocci commented Feb 23, 2024

Copy link
Copy Markdown
Contributor Author

@SylvainJuge, what's the required target goal? The same as

publishArg='publishToSonatype closeAndReleaseStagingRepository'

?

It's the same as the snapshot, so:

 publishArg='publishToSonatype closeAndReleaseStagingRepository'

When run with a non-snapshot version it should publish to the releases repository.

Ref: e1864cd

@SylvainJuge SylvainJuge merged commit f1d56bc into main Feb 23, 2024
@SylvainJuge SylvainJuge deleted the feat/release-process branch February 23, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants