Skip the navigation item if the parent group points to the same file#707
Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This PR updates the navigation rendering logic in the _TocTreeNav.cshtml view so that a navigation item is skipped if its parent group points to the same file.
- Updated condition in the FileNavigation check to compare file names.
Reviewed Changes
| File | Description |
|---|---|
| src/Elastic.Markdown/Slices/Layout/_TocTreeNav.cshtml | Modified the condition to skip a navigation item if its file name matches the parent index file name. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Elastic.Markdown/Slices/Layout/_TocTreeNav.cshtml:11
- [nitpick] The naming of the variable 'file' and its property 'File' can be confusing. Consider using more descriptive names to improve code clarity.
if (item is FileNavigation file && Model.SubTree.Index?.FileName != file.File.FileName)
Mpdreamz
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #443