Skip to content

Speed up dotnet format lint hook from ~85s to ~13s #3420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mpdreamz wants to merge 1 commit into from
Closed

Speed up dotnet format lint hook from ~85s to ~13s #3420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions build/Targets.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,15 @@ let private watch _ = exec { run "dotnet" "watch" "--project" "src/tooling/docs-

let private lint (lintArgs: ParseResults<LintArgs>) =
let includeFiles = lintArgs.TryGetResult LintArgs.Include |> Option.defaultValue []
let includeArgs =
if includeFiles.IsEmpty then []
else ["--include"] @ includeFiles
// When files are provided (pre-push hook): whitespace only — style/analyzers require full Roslyn
// semantic analysis (~60s extra) and are not accidentally introduced during normal coding.
// When no files (CI): full check, but skip restore since packages are already available.
let formatArgs =
match includeFiles with
| [] -> ["format"; "--verify-no-changes"; "--no-restore"]
| files -> ["format"; "whitespace"; "--verify-no-changes"; "--no-restore"; "--include"] @ files
match exec {
exit_code_of "dotnet" (["format"; "--verify-no-changes"] @ includeArgs)
exit_code_of "dotnet" formatArgs
} with
| 0 -> printfn "There are no dotnet formatting violations, continuing the build."
| _ -> failwithf "There are dotnet formatting violations. Call `dotnet format` to fix or specify -c to ./build.sh to skip this check"
Expand Down
Loading