[Rule Tuning] RDP (Remote Desktop Protocol) from the Internet#5932
Open
eric-forte-elastic wants to merge 17 commits intomainfrom
Conversation
…-from-the-internet-8c1bdde8-4204-45c0-9e0c-c85ca3902488
Contributor
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
|
⛔️ Test failed Results
|
…nternet-8c1bdde8-4204-45c0-9e0c-c85ca3902488' of https://github.com/elastic/detection-rules into 5507-rule-tuning-rdp-remote-desktop-protocol-from-the-internet-8c1bdde8-4204-45c0-9e0c-c85ca3902488
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue link(s):
Resolves #5507
Summary - What I changed
Note
#5922 should be merged first
Small logical change to update this rule to ES|QL and use
cidr_matchinstead of KQL comparison. KQL's CIDR syntax (source.ip: 10.0.0.0/8) only performs actual subnet matching when the Elasticsearch field mapping is ip type. Across mixed index patterns (packetbeat-, auditbeat-, filebeat-*, etc.), field types are not guaranteed. As such KQL silently falls back to a literal string comparison, so source.ip: 10.0.0.0/8 would never match a real IP address like 10.1.0.123One can verify this in telemetry using source/dest ip address filtering. Furthermore, one can verify that the integrations used all use either ECS mappings (where source and dest are of type ip) or directly map to ip.
Also needed to update datastreams for Zeek integration reformat:
Given that this issue affects additional rules, 4 additional rules have been tuned with similar updates in this PR. The rule
rules/network/initial_access_smb_windows_file_sharing_activity_to_the_internet.tomlis left as it is due to it being a new_terms rule with additional tuning implications that are separate from these rules. Tuning that rule will be done as part of #4268 which will include additional data sources.Additional rule modifications adding "Zeek" as an integration are required due to the integrations update adding Zeek.
How To Test
Verify in Telemetry.
Checklist
bug,enhancement,schema,maintenance,Rule: New,Rule: Deprecation,Rule: Tuning,Hunt: New, orHunt: Tuningso guidelines can be generatedmeta:rapid-mergelabel if planning to merge within 24 hoursContributor checklist