Skip to content

[Tuning] Execution via GitHub Actions Runner#5892

Open
Samirbous wants to merge 4 commits intomainfrom
entrypt
Open

[Tuning] Execution via GitHub Actions Runner#5892
Samirbous wants to merge 4 commits intomainfrom
entrypt

Conversation

@Samirbous
Copy link
Copy Markdown
Contributor

@Samirbous Samirbous commented Mar 27, 2026

adds execution from GH runner entrypoint script to the rule scope as well as few binaries.

@Samirbous
[Tuning] Execution via GitHub Actions Runner
36415cf 
adds execution from GH runner entrypoint script to the rule scope as well as few binaries.
@Samirbous Samirbous self-assigned this Mar 27, 2026
@Samirbous Samirbous added Rule: Tuning tweaking or tuning an existing rule Domain: Endpoint labels Mar 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

  • Detailed description of the suggested changes.
  • Provide example JSON data or screenshots.
  • Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
  • Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
  • Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
  • Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
  • Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
  • Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
  • Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
  • Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
  • Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
  • Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

  • updated_date matches the date of tuning PR merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

  • Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
  • Ensure that the tuned rule has a low false positive rate.

@tradebot-elastic
Copy link
Copy Markdown

tradebot-elastic commented Mar 27, 2026 •
edited
Loading

⛔️ Test failed

Results
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@tradebot-elastic
Copy link
Copy Markdown

tradebot-elastic commented Mar 27, 2026 •
edited
Loading

⛔️ Test failed

Results
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@tradebot-elastic
Copy link
Copy Markdown

tradebot-elastic commented Mar 27, 2026 •
edited
Loading

⛔️ Test failed

Results
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

DefSecSentinel
DefSecSentinel reviewed Mar 27, 2026
View reviewed changes
Comment thread rules/cross-platform/execution_via_github_actions_runner.toml
Comment thread rules/cross-platform/execution_via_github_actions_runner.toml
@DefSecSentinel DefSecSentinel mentioned this pull request Mar 27, 2026
Open
@tradebot-elastic
Copy link
Copy Markdown

tradebot-elastic commented Mar 27, 2026 •
edited
Loading

⛔️ Test failed

Results
  • ❌ Execution via GitHub Actions Runner (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@DefSecSentinel DefSecSentinel self-requested a review April 1, 2026 14:32
DefSecSentinel
DefSecSentinel approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@DefSecSentinel DefSecSentinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the responses. Looks good.

terrancedejesus
terrancedejesus reviewed Apr 1, 2026
View reviewed changes
Comment thread rules/cross-platform/execution_via_github_actions_runner.toml
/* Secret management */
"vault",
/* GitHub CLI */
"gh"
Copy link
Copy Markdown
Contributor

@terrancedejesus terrancedejesus Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"gh"
"gh",
/* AWS CLI */
aws,
/*Azure CLI */
az,
/*GCP CLI */
gcloud,
/* Google Workspace CLI */
gws

We can add cloud CLIs, but there is a chance that FPs will increase especially if these are runners whom leverage these to accomplish auth/ops.

terrancedejesus
terrancedejesus reviewed Apr 1, 2026
View reviewed changes
Comment thread rules/cross-platform/execution_via_github_actions_runner.toml
/* Crypto / encoding (potential exfiltration or C2 channel) */
"openssl", "base64",
/* Data manipulation / inspection */
"tr", "cat",
Copy link
Copy Markdown
Contributor

@terrancedejesus terrancedejesus Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious if we should add grep, sed, awk here for common credential recon.

Aegrah
Aegrah approved these changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Aegrah Aegrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additions, LGTM

Comment thread rules/cross-platform/execution_via_github_actions_runner.toml
/* Windows scripting & LOLBins */
"powershell.exe", "cmd.exe", "pwsh.exe", "certutil.exe", "rundll32.exe",
/* Unix shells */
"bash", "sh", "zsh", "dash", "ash", "tcsh", "csh", "ksh", "fish",
Copy link
Copy Markdown
Contributor

@Aegrah Aegrah Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"bash", "sh", "zsh", "dash", "ash", "tcsh", "csh", "ksh", "fish",
"bash", "sh", "zsh", "dash", "ash", "tcsh", "csh", "ksh", "fish", "mksh", "busybox", "pwsh",

Comment thread rules/cross-platform/execution_via_github_actions_runner.toml
/* Unix shells */
"bash", "sh", "zsh", "dash", "ash", "tcsh", "csh", "ksh", "fish",
/* File / archive manipulation */
"tar", "rm", "sed", "chmod",
Copy link
Copy Markdown
Contributor

@Aegrah Aegrah Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"tar", "rm", "sed", "chmod",
"tar", "gzip", "rm", "sed", "chmod",

Comment thread rules/cross-platform/execution_via_github_actions_runner.toml
/* Process persistence helpers */
"nohup", "setsid",
/* Scripting runtimes */
"python*", "perl*", "ruby*", "lua*", "php*", "node", "node.exe",
Copy link
Copy Markdown
Contributor

@Aegrah Aegrah Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"python*", "perl*", "ruby*", "lua*", "php*", "node", "node.exe",
"python*", "perl*", "ruby*", "lua*", "php*", "node", "nodejs", "node.exe",

Comment thread rules/cross-platform/execution_via_github_actions_runner.toml
/* Discovery & reconnaissance */
"pgrep", "grep", "find", "printenv", "env", "nmap",
/* Crypto / encoding (potential exfiltration or C2 channel) */
"openssl", "base64",
Copy link
Copy Markdown
Contributor

@Aegrah Aegrah Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"openssl", "base64",
"openssl", "base64", "basez", "base64plain", "base64url", "base64mime", "base64pem", "basenc", "base32", "base16", "xxd",

Comment thread rules/cross-platform/execution_via_github_actions_runner.toml
/* Data manipulation / inspection */
"tr", "cat",
/* Network relay / tunneling */
"nc", "ncat", "netcat", "socat", "wg", "wg-quick",
Copy link
Copy Markdown
Contributor

@Aegrah Aegrah Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"nc", "ncat", "netcat", "socat", "wg", "wg-quick",
"nc", "ncat", "netcat", "nc.traditional", "nc.openbsd", "socat", "wg", "wg-quick",

Comment thread rules/cross-platform/execution_via_github_actions_runner.toml
/* Network relay / tunneling */
"nc", "ncat", "netcat", "socat", "wg", "wg-quick",
/* Remote access */
"ssh", "ssh.exe",
Copy link
Copy Markdown
Contributor

@Aegrah Aegrah Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"ssh", "ssh.exe",
"ssh", "ssh.exe", "ftp", "tftp", "scp", "sftp",

Comment thread rules/cross-platform/execution_via_github_actions_runner.toml
/* Remote access */
"ssh", "ssh.exe",
/* Kubernetes / infrastructure */
"kubectl", "helm",
Copy link
Copy Markdown
Contributor

@Aegrah Aegrah Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"kubectl", "helm",
"kubectl", "helm", "docker", "ctr", "crictl",

Comment thread rules/cross-platform/execution_via_github_actions_runner.toml
Comment on lines +162 to +163
/* GitHub CLI */
"gh"
Copy link
Copy Markdown
Contributor

@Aegrah Aegrah Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* GitHub CLI */
"gh"
/* GitHub CLI */
"gh",
/* Misc. */
"kill", "killall", "pkill", "getcap", "capsh", "chpasswd", "dd"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terrancedejesus terrancedejesus terrancedejesus approved these changes

@DefSecSentinel DefSecSentinel DefSecSentinel approved these changes

@Aegrah Aegrah Aegrah approved these changes

@w0rk3r w0rk3r Awaiting requested review from w0rk3r

@Mikaayenson Mikaayenson Awaiting requested review from Mikaayenson

Assignees

@Samirbous Samirbous

Labels

backport: auto Domain: Endpoint Rule: Tuning tweaking or tuning an existing rule

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Samirbous @tradebot-elastic @DefSecSentinel @Aegrah @terrancedejesus @Mikaayenson