Skip to content

Reduce time in Cloudbeat CI#773

Merged
oren-zohar merged 1 commit into
elastic:mainfrom
ofiriro3:increase_timeout_for_ci_job
Feb 26, 2023
Merged

Reduce time in Cloudbeat CI#773
oren-zohar merged 1 commit into
elastic:mainfrom
ofiriro3:increase_timeout_for_ci_job

Conversation

@ofiriro3

Copy link
Copy Markdown
Contributor

Summary of your changes

After multiple attemps to run the unit-test.yml in the CI, it seems that it the racing validation step causes a timeout.
Instead of increasing the step timeout, and by that increasing the general time that the CI runs, we would like to merge to steps in the CI:

  • The race validation check
  • Coverage and unit test step

By merging these two into one step we hope to get the same result in less CI time.

@mergify

mergify Bot commented Feb 26, 2023

Copy link
Copy Markdown
Contributor

This pull request does not have a backport label. Could you fix it @ofiriro3? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@oren-zohar

Copy link
Copy Markdown
Collaborator

it's not because of the race flag, and we need this flag, closing

@oren-zohar oren-zohar closed this Feb 26, 2023
@olegsu

olegsu commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

@oren-zohar the flag was just moved to the unit test, so we don't run the unit test twice.

@oren-zohar

Copy link
Copy Markdown
Collaborator

will be fixed here (+ using the go dependencies caching to further reduce the running time)

@ofiriro3 ofiriro3 reopened this Feb 26, 2023
@ofiriro3
ofiriro3 marked this pull request as ready for review February 26, 2023 10:40
@ofiriro3
ofiriro3 requested a review from a team as a code owner February 26, 2023 10:40
@oren-zohar
oren-zohar enabled auto-merge (squash) February 26, 2023 10:51
@oren-zohar
oren-zohar merged commit 473fee2 into elastic:main Feb 26, 2023
@ofiriro3
ofiriro3 deleted the increase_timeout_for_ci_job branch February 26, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants