Add benchmark id field to schema#294
Merged
Merged
Conversation
orouz
commented
Jul 24, 2022
Collaborator
Contributor
|
This pull request does not have a backport label. Could you fix it @orouz? 🙏
|
Cloudbeat CI 🤖Allure Report: http://csp-allure-reports.s3.amazonaws.com/allure_reports/cloudbeat/prs/294/index.html |
oren-zohar
approved these changes
Jul 24, 2022
oren-zohar
left a comment
Collaborator
There was a problem hiding this comment.
Should add tests as part of the opa.go tests, but there aren't any tests for it. If you want to add a test to opa.go that would be great but it's definitely too much to ask for such a small change
orouz
added a commit
to orouz/cloudbeat
that referenced
this pull request
Sep 6, 2023
orestisfl
pushed a commit
to orestisfl/cloudbeat
that referenced
this pull request
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.