add temp master ci#1
Closed
amirbenun wants to merge 1 commit into
Closed
Conversation
Collaborator
|
I think we can close this one |
kfirpeled
referenced
this pull request
in kfirpeled/cloudbeat
Apr 11, 2022
orouz
referenced
this pull request
in orouz/cloudbeat
Sep 6, 2023
* Add files via upload * Update worker.js * Merge pull request #1 from ofiriro3/editing-readme Adding information to readme.md * Merge pull request #2 from ofiriro3/editing-readme Indentation + path for csp * Update README.md Adding a bit of information regarding the manual process of rules * Merge pull request #3 from jeniawhite/add-json-gen add json rule generator * Add an option to generate report for missing rules (#4) * Rule template schema changes - introducing `metadata` field * temp solution for merge * Initial commit * move to subfolder * revert temp * mv .gitattributes Co-authored-by: Evgeniy Belyi <jeniawhite92@gmail.com> Co-authored-by: ofiriro3 <ofiriro3@Gmail.com> Co-authored-by: Uri Weisman <68195305+uri-weisman@users.noreply.github.com> Co-authored-by: Kfir Peled <61654899+kfirpeled@users.noreply.github.com>
orestisfl
referenced
this pull request
in orestisfl/cloudbeat
Oct 11, 2023
* Add files via upload * Update worker.js * Merge pull request #1 from ofiriro3/editing-readme Adding information to readme.md * Merge pull request #2 from ofiriro3/editing-readme Indentation + path for csp * Update README.md Adding a bit of information regarding the manual process of rules * Merge pull request #3 from jeniawhite/add-json-gen add json rule generator * Add an option to generate report for missing rules (#4) * Rule template schema changes - introducing `metadata` field * temp solution for merge * Initial commit * move to subfolder * revert temp * mv .gitattributes Co-authored-by: Evgeniy Belyi <jeniawhite92@gmail.com> Co-authored-by: ofiriro3 <ofiriro3@Gmail.com> Co-authored-by: Uri Weisman <68195305+uri-weisman@users.noreply.github.com> Co-authored-by: Kfir Peled <61654899+kfirpeled@users.noreply.github.com>
gsarantid
referenced
this pull request
in gsarantid/cloudbeat
Jul 6, 2026
## Summary Follow-up to InfoSec's review of elastic#6991. Adds the remaining EC2 and ELB fields InfoSec needs to retire their custom AWS CLI scripts for the FedRAMP asset inventory. All new fields land in `entity.attributes.*` (non-ECS, UpperCamelCase) — no ECS mapping change required. Tracking: elastic/security-team#17750 ## Changes **EC2** (`entity.attributes`): - `ImageId`, `Platform`, `VpcId`, `SubnetId`, `State`, `RoleArn` - `Owner`, `CostCenter` — resolved case-insensitively from instance tags **ELB v1 + v2** (`entity.attributes`): - `LoadBalancerType` — v2 reports the real type; v1 reports `classic` - `AccountID` - `State` — v2 only (`State.Code`); classic ELB exposes no state field - `IPAddresses` — NLB static IPs; ALB/classic are DNS-only (empty) - `OwnerTag` — required adding `DescribeTags` to both ELB `Client` interfaces and providers (batched to the 20-item AWS limit) ## Notes - No `elastic/integrations` change: `entity.attributes` is `flattened`, so new keys need no mapping and there's no migration. - No new asset classifications, so `ASSETS.md` is unchanged. Route53 and EKS (also requested in the review) are separate follow-up PRs. - Mocks regenerated; unit tests cover EC2 attributes and the ELB Type/State/IPAddresses/OwnerTag flow end-to-end. --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.