Skip to content

test: isolate store singleton from cross-file bun leaks #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshMock merged 1 commit into from
May 29, 2026
Merged

test: isolate store singleton from cross-file bun leaks #386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions test/config/store.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
* SPDX-License-Identifier: Apache-2.0
*/

import { describe, it, afterEach } from 'node:test'
import { describe, it, beforeEach, afterEach } from 'node:test'
import assert from 'node:assert/strict'
import { setResolvedConfig, getResolvedConfig } from '../../src/config/store.ts'
import { setResolvedConfig, getResolvedConfig, _testResetConfig } from '../../src/config/store.ts'
import type { ResolvedConfig } from '../../src/config/types.ts'

const sampleConfig: ResolvedConfig = {
Expand All @@ -14,9 +14,15 @@ const sampleConfig: ResolvedConfig = {
},
}

// The store is a module-level singleton. Under `bun test` all files share one
// process, so other suites can leave state behind; reset before each test (not
// just after) so assertions about the initial state are order-independent.
beforeEach(() => {
_testResetConfig()
})

afterEach(() => {
// reset singleton state between tests
setResolvedConfig(undefined as unknown as ResolvedConfig)
_testResetConfig()
})

describe('store', () => {
Expand Down
Loading