fix: Surface meaningful error messages for connection failures#122
Merged
Conversation
…lures ConnectionError and TimeoutError from @elastic/transport now produce distinct error codes (connection_error, timeout_error) with descriptive messages including the target URL when available, instead of the generic transport_error with an empty message. Closes #99
Contributor
Author
|
This fix works around two upstream issues in
If those are addressed upstream, the |
JoshMock
approved these changes
Apr 13, 2026
… module Adapts to the refactor that extracted error helpers into src/es/errors.ts. Removes stale local copies from handler.ts and moves the ConnectionError and TimeoutError branches into the shared module. Reverts `??` back to `||` for message fallbacks: empty string is the bug scenario (elastic/elastic-transport-js#366), so we need falsy checks, not just nullish checks.
Contributor
Author
|
Hey @JoshMock, a small note on the |
JoshMock
approved these changes
Apr 13, 2026
Member
|
Thanks for catching that @MattDevy! ❤️ |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connection_errorcode with the target URL appended to the message (e.g.,connection failed (http://localhost:19999/)) instead of an emptytransport_errormessagetimeout_errorcode with the original timeout message preservedtransport_errorfor any other error typesTest plan
Closes #99