Skip to content

Cast to parent buffer for Java 8 buffer method compatibility#4498

Merged
jackshirazi merged 6 commits into
elastic:mainfrom
jackshirazi:casting-to-parent-buffer-again
Jun 4, 2026
Merged

Cast to parent buffer for Java 8 buffer method compatibility#4498
jackshirazi merged 6 commits into
elastic:mainfrom
jackshirazi:casting-to-parent-buffer-again

Conversation

@jackshirazi
Copy link
Copy Markdown
Contributor

@jackshirazi jackshirazi commented Jun 2, 2026

What does this PR do?

Fixes java.lang.NoSuchMethodError: java.nio.ByteBuffer.clear()Ljava/nio/ByteBuffer;
at co.elastic.apm.agent.impl.context.BodyCaptureImpl$2.recycle(BodyCaptureImpl.java:44) ~[elastic-apm-agent-1.52.0.jar:1.52.0]
and similar

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.next-release.md
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.next-release.md
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.md
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@jackshirazi jackshirazi marked this pull request as ready for review June 4, 2026 14:20
@jackshirazi jackshirazi requested a review from a team as a code owner June 4, 2026 14:20
@jackshirazi jackshirazi enabled auto-merge (squash) June 4, 2026 14:59
@jackshirazi jackshirazi merged commit 9ff9030 into elastic:main Jun 4, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants