Skip to content

feat(ci): reapply of capybara pages deployment and fix issues#1049

Merged
wdconinc merged 11 commits intomainfrom
reapply-capybara
Apr 22, 2026
Merged

feat(ci): reapply of capybara pages deployment and fix issues#1049
wdconinc merged 11 commits intomainfrom
reapply-capybara

Conversation

@wdconinc
Copy link
Copy Markdown
Contributor

@wdconinc wdconinc commented Feb 26, 2026

Briefly, what does this PR introduce?

Reverts 6821c01 (re-applies a604499) with the following fixes:

  • Fix matrix.head_sha reference in get-docs-from-main (no matrix in that job), and use 'branch: main' to download from the main branch
  • Fix download path in build-artifacts-page: copy github-pages-staging-* artifacts from already-downloaded artifacts/ into _site/ after Jekyll build, avoiding unreliable parallel multi-artifact downloads
  • Use if-no-files-found: ignore for get-docs-from-main upload to handle case where main branch has no capybara artifact yet
  • Add continue-on-error: true to deploy-pages step so PR comments are still posted even if GitHub Pages environment protection blocks deployment from PR branches
  • Guard capybara find against missing directory when npsim has not yet produced reports
  • Update action versions to match current workflow (dawidd6 v20, upload-artifact v7, download-artifact v8, upload-pages-artifact v5, deploy-pages v5)

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue: capybara)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

Copilot AI review requested due to automatic review settings February 26, 2026 02:25
@github-actions github-actions Bot added the topic: infrastructure Regarding build system, CI, CD label Feb 26, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the linux-eic-shell GitHub Actions workflow to (re-)enable publishing Capybara report artifacts into the GitHub Pages site, including collecting artifacts from open PRs and main.

Changes:

  • Renames/standardizes the merged Capybara artifact to capybara and adds jobs to collect Capybara artifacts from open PRs and from main.
  • Adjusts the GitHub Pages build job to merge “staging” artifacts into the Jekyll _site/ output before uploading the Pages artifact.
  • Extends the deploy job to post/update a “Capybara summary” PR comment (and modifies job permissions accordingly).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/linux-eic-shell.yml
Comment thread .github/workflows/linux-eic-shell.yml
Comment thread .github/workflows/linux-eic-shell.yml Outdated
@wdconinc wdconinc changed the title feat(ci): revert revert of capybara pages deployment and fix issues feat(ci): reapply of capybara pages deployment and fix issues Feb 26, 2026
Comment thread .github/workflows/linux-eic-shell.yml
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

Comment thread .github/workflows/linux-eic-shell.yml Outdated
Comment thread .github/workflows/linux-eic-shell.yml Outdated
@wdconinc wdconinc enabled auto-merge (squash) April 22, 2026 12:35
Copy link
Copy Markdown
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice. Diff LGTM.

wdconinc and others added 11 commits April 22, 2026 09:27
Reverts 6821c01 (re-applies
a604499) with the following fixes:

- Fix matrix.head_sha reference in get-docs-from-main (no matrix in
  that job): use 'branch: main' to download from the main branch
- Fix download path in build-artifacts-page: download github-pages-staging
  to _site/ (after jekyll build) instead of artifacts/ (from PR #859)
- Use if-no-files-found: ignore for get-docs-from-main upload to handle
  case where main branch has no capybara artifact yet
- Update action versions to match current workflow (dawidd6 v15,
  upload-artifact v6, download-artifact v7, upload-pages-artifact v4)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
When no capybara artifact exists on main yet (e.g. first run), the
get-docs-from-main job previously uploaded nothing (if-no-files-found:
ignore), leaving zero github-pages-staging-* artifacts for the merge
step in build-artifacts-page to find, causing it to fail with
'No artifacts found matching pattern'.

Add a step to always create publishing_docs/.keep so the upload
never has zero files, and change if-no-files-found to error so
any future regression is caught immediately.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- add continue-on-error: true to deploy-pages step so capybara PR
  comments are still posted even when GitHub Pages environment
  protection blocks deployment from PR branches
- guard 'find _site/pr/{n}/capybara/' against missing directory
  (e.g. when npsim has not yet produced reports)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- jekyll-build-pages@v1 runs as root, making _site/ unwritable;
  add sudo chown step after Jekyll build to restore runner ownership
- fix 'List content to publish' run: scalar (was parsed as YAML
  mapping due to indented value on next line)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>
@wdconinc wdconinc merged commit a010885 into main Apr 22, 2026
232 of 240 checks passed
@wdconinc wdconinc deleted the reapply-capybara branch April 22, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: infrastructure Regarding build system, CI, CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants