Skip to content

Add dummy migration for migration rollback testing#132

Open
zubair-arbi wants to merge 1 commit intodevelop-multisitefrom
zub/dummy-migration-for-rollback
Open

Add dummy migration for migration rollback testing#132
zubair-arbi wants to merge 1 commit intodevelop-multisitefrom
zub/dummy-migration-for-rollback

Conversation

@zubair-arbi
Copy link
Copy Markdown

@zubair-arbi zubair-arbi commented Aug 7, 2020

Jira Ticket: EDLY-1708
Related Ticket: EDLY-911

This branch was create to create a dummy migration which can be used by the devops to test release rollback including the migrations.

Testing Instructions:

  1. Create a new dummy release tag for testing this change on stage multisites edly-test-1.1.0
  2. Devops will deploy this release tag
  3. Verify that changes are on stage (the dummy_field in EdlyUserProfile model)
  4. Devops will rollback this release by reverting to previous stable release tag edly-2.3.0 (https://github.com/edly-io/edx-platform/releases/tag/edly-2.3.0)
  5. Verify that ansible playbook for rollback is successfully commpleted without any error
  6. Verify that the changes are stage (the dummy_field in EdlyUserProfile model) were reverted

Note: Don't merge this PR. Its created for testing purpose only.

@zubair-arbi
Copy link
Copy Markdown
Author

@ziafazal @NIXKnight @jamshedali20 I have created this PR with a test migration for release rollback testing.

I have also create the test release https://github.com/edly-io/edx-platform/releases/tag/edly-test-1.0.0 against it.

@zubair-arbi zubair-arbi force-pushed the zub/dummy-migration-for-rollback branch from e13b0d3 to 6ae11ec Compare October 6, 2020 11:13
@NIXKnight
Copy link
Copy Markdown

This PR has been open since October 2020 and the description explicitly states "Don't merge this PR". It was created for migration rollback testing.

If the testing has been completed, this PR should be closed. If the testing is still needed, consider:

  1. The migration (line 18) uses a bytes literal help_text=b'...' which was auto-generated by Django 1.11 for Python 2 compatibility. On Python 3 this will cause issues since help_text expects a string, not bytes.
  2. The model definition in models.py correctly uses a regular string help_text='...', so only the migration file has the mismatch.

Recommendation: close this PR.

Copy link
Copy Markdown

@NIXKnight NIXKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment for details. This 5-year-old PR should be closed.

@jamshedali20
Copy link
Copy Markdown

@muhammadali286 could you please look into it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants