feat: add Empleado CRUD module with tests and security validation#20
Closed
edelomeza wants to merge 5 commits into
Closed
feat: add Empleado CRUD module with tests and security validation#20edelomeza wants to merge 5 commits into
edelomeza wants to merge 5 commits into
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
|
||
| serviceMock | ||
| .Setup(x => x.GetEmpleadosAsync(It.IsAny<int>(), It.IsAny<int>(), It.IsAny<CancellationToken>())) | ||
| .ReturnsAsync((PaginatedResponse<Empleado>?)null); |
|
|
||
| serviceMock | ||
| .Setup(x => x.GetEmpleadosAsync(It.IsAny<int>(), It.IsAny<int>(), It.IsAny<CancellationToken>())) | ||
| .ReturnsAsync((PaginatedResponse<Empleado>?)null); |
|
|
||
| serviceMock | ||
| .Setup(x => x.GetEmpleadoByIdAsync(It.IsAny<int>(), It.IsAny<CancellationToken>())) | ||
| .ReturnsAsync((Empleado?)null); |
Comment on lines
+267
to
+271
| catch (Exception ex) | ||
| { | ||
| _logger.LogError(ex, "Unexpected error updating empleado {Id}", id); | ||
| return OperationResult.Fail("Error inesperado. Intente nuevamente."); | ||
| } |
Comment on lines
+209
to
+213
| catch (Exception ex) | ||
| { | ||
| _logger.LogError(ex, "Unexpected error creating empleado"); | ||
| return OperationResult.Fail("Error inesperado. Intente nuevamente."); | ||
| } |
Comment on lines
+155
to
+159
| catch (Exception ex) | ||
| { | ||
| _logger.LogError(ex, "Unexpected error fetching empleado {Id}", id); | ||
| return null; | ||
| } |
Comment on lines
+109
to
+113
| catch (Exception ex) | ||
| { | ||
| _logger.LogError(ex, "Unexpected error searching empleados"); | ||
| return null; | ||
| } |
Comment on lines
+58
to
+62
| catch (Exception ex) | ||
| { | ||
| _logger.LogError(ex, "Unexpected error fetching empleados"); | ||
| return null; | ||
| } |
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Owner
Author
|
se realizaron mejoras en una preubas y se concluyo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Se agrego crud de empleado y catalogo tipo empleado