feat(cli): add Ctrl+S keyboard shortcut for quick save states #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement instant save state functionality via Ctrl+S during CLI gameplay.
When pressed, creates a timestamped save file in the format:
{rom_name}_save_{counter}_{timestamp}.state
Features:
- Non-blocking save during gameplay
- Auto-generated filenames with timestamps
- Sequential counter for multiple saves per session
- User feedback with success/error messages
- Updated help text and controls display
Technical implementation:
- Added callback mechanism to CliInput for Ctrl+S (ASCII 19)
- Save callback registered in bin/phpboy.php
- Uses existing saveState() API from Emulator class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement instant save state functionality via Ctrl+S during CLI gameplay.
When pressed, creates a timestamped save file in the format:
{rom_name}save{counter}_{timestamp}.state
Features:
Technical implementation: