Skip to content

CV Template: Implement collapsible metadata - #40

Merged
saraedum merged 16 commits into
echemdb:mainfrom
DunklesArchipel:templatemetadata
Nov 14, 2021
Merged

CV Template: Implement collapsible metadata#40
saraedum merged 16 commits into
echemdb:mainfrom
DunklesArchipel:templatemetadata

Conversation

@DunklesArchipel

Copy link
Copy Markdown
Member

I do not know how to convert the package into a dict. So currently it is entry.package.to_dict(), however, to_dict seems to be deprecated. There should be another solution to the problem.

@DunklesArchipel

Copy link
Copy Markdown
Member Author

I do not know how to convert the package into a dict. So currently it is entry.package.to_dict(), however, to_dict seems to be deprecated. There should be another solution to the problem.

I found the workaround.

@DunklesArchipel
DunklesArchipel marked this pull request as ready for review November 12, 2021 08:17
Comment thread templates/cv_entry.md Outdated
Comment thread echemdb/data/cv/entry.py Outdated

@saraedum saraedum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But there are some merge conflicts.

@saraedum
saraedum merged commit 5043a1c into echemdb:main Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants