-
Notifications
You must be signed in to change notification settings - Fork 3
Add rescaling of reference scales in EchemdbEntry #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DunklesArchipel
merged 48 commits into
echemdb:main
from
DunklesArchipel:rescale-reference
Jan 15, 2026
Merged
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
d36d775
Add rescaling of reference scales in EchemdbEntry
DunklesArchipel 28cecf9
Query pH from entry metadata for parsing in reference conversion
DunklesArchipel 02d4c3a
Merge remote-tracking branch 'origin/main' into rescale-reference
DunklesArchipel f6ec281
include module for reference shifts
DunklesArchipel 53e7d68
Add method `add offset`
DunklesArchipel 58671b7
Merge remote-tracking branch 'origin/main' into rescale-reference
DunklesArchipel f4a5b0d
Merge remote-tracking branch 'albert/rescale-reference' into rescale-…
DunklesArchipel 25f58ec
Fix licencse
DunklesArchipel 786b5dc
Move add_offset to base entry
DunklesArchipel 265ed83
Fix tests and modify docstring
DunklesArchipel f050206
Apply suggestions from code review
DunklesArchipel 40b54d4
Merge remote-tracking branch 'origin/main' into rescale-reference
DunklesArchipel 9377e98
Update offset information on consecutive offsets
DunklesArchipel 314322c
Fix calomel electrode
DunklesArchipel 6c5909f
Fix Ag/AgCl electrode
DunklesArchipel de0d78a
Fix build docu and lint
DunklesArchipel a089327
Add news
DunklesArchipel aa63552
Update documentation
DunklesArchipel ca8acbb
Add Hg/HgO reference electrodes
DunklesArchipel 0d02708
Merge remote-tracking branch 'origin/main' into rescale-reference
DunklesArchipel 98cdc37
fix add_offset logger warning
DunklesArchipel 75c1e31
Improve ReferenceElectrodes descriptions
DunklesArchipel c558cc1
fix lint
DunklesArchipel 0e48cc4
Adapt reference electrode schema
DunklesArchipel 7b05131
Move electrochemistry data in separate file
DunklesArchipel 80afb60
Add dataclass ReferenceElectrodeEntry
DunklesArchipel bbc24ba
refactor reference electrode
DunklesArchipel 07b1b90
Refactor reference electtrodes
DunklesArchipel b9312f7
fix copyright
DunklesArchipel b6b0645
Add saving as JSON
DunklesArchipel 5501cce
remove type annotation
DunklesArchipel 9a3f7e8
change preferred to standard in reference electrodes
DunklesArchipel d5e2bf8
Adapt code to variable standard rather than preferred
DunklesArchipel bd73c93
remove more typing and parametter definitions
DunklesArchipel 2ccc9e8
unknown
DunklesArchipel 6f506fb
Apply suggestions from code review
DunklesArchipel 279f253
remove duplicate reference values
DunklesArchipel b4f9bde
Merge remote-tracking branch 'albert/rescale-reference' into rescale-…
DunklesArchipel 5711595
remove duplicates and typos
DunklesArchipel 34dcb2c
improve doctests and tests
DunklesArchipel 8434467
improve dict and json creation
DunklesArchipel cb4f065
Fix dict creation and adapt docstrings
DunklesArchipel 39a6f71
fix lint
DunklesArchipel ebcd8d2
update news
DunklesArchipel 8959999
Adapt documentation
DunklesArchipel a8f0de5
Fix building docu
DunklesArchipel 4b31435
Fix suggestions
DunklesArchipel 141e9af
Merge branch 'main' into rescale-reference
DunklesArchipel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| github_url: https://github.com/echemdb/unitpackage/blob/master/unitpackage/electrochemistry/reference_electrode.py | ||
| --- | ||
|
|
||
| # `unitpackage.electrochemistry.reference_electrode` | ||
|
|
||
| ```{eval-rst} | ||
| .. automodule:: unitpackage.electrochemistry.reference_electrode | ||
| :members: | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| **Added:** | ||
|
|
||
| * Added `unitpackage.electrochemistry.reference_electrodes` which contains reference electrode data and a dataclass to interact with the data (`_reference_electrodes`), and a `ReferenceElectrode` object, which determining the shift of the potential between different reference scales. | ||
| * Added `Entry.add_offset` which allows shifting the values of a specified column of the entry by a certain offset and tracking the information in the fields description. | ||
| * Added `EchmdbEntry.rescale_reference` which allows shifting the potential scale onto another potential scale known to `unitpackage.electrochemistry._reference_electrodes`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.