Skip to content

Lighten the disabled foreground color in the dark theme#44

Merged
seventil merged 1 commit into
developfrom
new_dark_theme_disabled
Apr 22, 2026
Merged

Lighten the disabled foreground color in the dark theme#44
seventil merged 1 commit into
developfrom
new_dark_theme_disabled

Conversation

@seventil
Copy link
Copy Markdown
Contributor

While trying to choose the selection colors for a new ListView, I found it hard to choose the ones that would have enough contrast by themselves but also had contrast with disabled TableViewLabels in the delegate. But this issue existed only for the dark theme.
1_initial_contrast_dark
2_initial_contrast_light

So I opened the color wheels for the tableview background colors and disabled color:
3_HSB_for_colors

The contrast between light-theme disabled and background is ~25, but for dark theme it's just ~10.
Considering that dark-themed contrast shouldn't be 1to1 match to light-theme, I tried changing the color for the label to bump the contrast up. Here is how it looks with 666 color (17 points difference from the background): the type label has the original disabled color, while atoms column has the new 666 color.
4_proposed_contrast_dark

@seventil seventil requested a review from AndrewSazonov April 22, 2026 08:54
@seventil seventil self-assigned this Apr 22, 2026
@seventil seventil added [scope] bug Bug report or fix (major.minor.PATCH) [priority] lowest Very low urgency labels Apr 22, 2026
Copy link
Copy Markdown
Member

@AndrewSazonov AndrewSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking back at the EasyDiffraction work, I now remember that I changed themeForegroundDisabled to themeForegroundMinor in several places for a similar reason. It was not about selection, but about making non-editable text easier to see against the background. So I am fine with merging this for now, because the new color makes disabled items clearer in dark mode. Later, we should discuss whether we still need both themeForegroundMinor and themeForegroundDisabled, or if they should be merged into one.

@seventil seventil merged commit aa91ac0 into develop Apr 22, 2026
@AndrewSazonov AndrewSazonov deleted the new_dark_theme_disabled branch April 29, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[priority] lowest Very low urgency [scope] bug Bug report or fix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants