Lighten the disabled foreground color in the dark theme#44
Merged
Conversation
AndrewSazonov
approved these changes
Apr 22, 2026
Member
AndrewSazonov
left a comment
There was a problem hiding this comment.
Looking back at the EasyDiffraction work, I now remember that I changed themeForegroundDisabled to themeForegroundMinor in several places for a similar reason. It was not about selection, but about making non-editable text easier to see against the background. So I am fine with merging this for now, because the new color makes disabled items clearer in dark mode. Later, we should discuss whether we still need both themeForegroundMinor and themeForegroundDisabled, or if they should be merged into one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to choose the selection colors for a new ListView, I found it hard to choose the ones that would have enough contrast by themselves but also had contrast with disabled TableViewLabels in the delegate. But this issue existed only for the dark theme.


So I opened the color wheels for the tableview background colors and disabled color:

The contrast between light-theme disabled and background is ~25, but for dark theme it's just ~10.

Considering that dark-themed contrast shouldn't be 1to1 match to light-theme, I tried changing the color for the label to bump the contrast up. Here is how it looks with 666 color (17 points difference from the background): the type label has the original disabled color, while atoms column has the new 666 color.