168 Separate files for the GUI part to manipulate an item type#172
Closed
andped10 wants to merge 5 commits into
Closed
168 Separate files for the GUI part to manipulate an item type#172andped10 wants to merge 5 commits into
andped10 wants to merge 5 commits into
Conversation
…ype' of https://github.com/easyScience/EasyReflectometryApp into 168-template-for-the-gui-object-to-manipulate-an-item-type
…late-an-item-type
Collaborator
Author
|
No longer relevant. Handled in #217 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make the code more readable the code for the different item types (layer assemblies) should be better separated. Now the lowest part of the Sample pane is loaded as a whole rather than being an if-else construct.
Extracting the GUI for an assembly of layers into separate files.
In the future we would probably find a better way to handle the update of the spin wheel in for the repeating layers part. For now the problem is solved by placing the property in the
SideBarBasicfile rather than in the file for theRepeatingMultiLayers.