-
Notifications
You must be signed in to change notification settings - Fork 64
Add timeframe parameter to list_vulnerabilities and get_kubernetes_events tools #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ents tools Co-authored-by: christian-kreuzberger-dtx <[email protected]>
Co-authored-by: christian-kreuzberger-dtx <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds configurable timeframe parameters to two DQL-based tools (list_vulnerabilities and get_kubernetes_events), allowing users to query events and vulnerabilities beyond hardcoded time windows. This follows the pattern already established by the list_problems tool which was enhanced in a previous PR.
Key Changes:
- Added
timeframeparameter tolist_vulnerabilitieswith default "30d" - Added
timeframeparameter toget_kubernetes_eventswith default "24h" - Fixed pre-existing spacing issue in
get-events-for-cluster.ts(missing space before pipe character)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/index.ts |
Added timeframe parameter to tool definitions, updated handler functions to pass timeframe, and updated response messages to reference the configurable timeframe |
src/capabilities/list-vulnerabilities.ts |
Added timeframe parameter to function signature with default "30d", updated DQL query to use configurable timeframe, and added comprehensive JSDoc documentation |
src/capabilities/get-events-for-cluster.ts |
Added timeframe parameter to function signature with default "24h", updated DQL query to use configurable timeframe, added comprehensive JSDoc documentation, and fixed spacing before pipe character |
CHANGELOG.md |
Added entries documenting the new timeframe parameters for both tools with examples and default values |
|
@copilot please resolve any conflicts |
I've successfully resolved the merge conflicts by rebasing on main. The branch now includes both the timeframe parameter additions and the dependency updates from main (MCP SDK upgrade to v1.24.3 and security fixes for jws and node-forge). All tests pass. The changes are ready in commit ac874b0. |
list_problemstool as reference (already has a timeframe parameter)list_vulnerabilitiestool (default: "30d")get_kubernetes_eventstool (default: "24h")Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.