generated from dynatrace-oss/template-project
-
Notifications
You must be signed in to change notification settings - Fork 64
Fix integration tests #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
christian-kreuzberger-dtx
merged 4 commits into
dynatrace-oss:main
from
aledsage:fix-tests
Oct 23, 2025
Merged
Fix integration tests #220
christian-kreuzberger-dtx
merged 4 commits into
dynatrace-oss:main
from
aledsage:fix-tests
Oct 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
See #221 for tracking the issue of the failing integration tests. |
christian-kreuzberger-dtx
approved these changes
Oct 23, 2025
Collaborator
christian-kreuzberger-dtx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Original test send-email.integration.test.ts failed because createDtHttpClient now throws the authorization exception, not sendEmail. - Moved authentication test into its own dynatrace-clients.integration.test.ts - Create authorization test for send-email
- Use findMonitoredEntitiesByName (the old findMonitoredEntityByName no longer exists) - Result is no longer a string, but a DqlExecutionResult - Fix when no entities provided (throw exception) - Removed test for empty string (instead have test for empty list of entities)
d9e1709 to
8cd02c8
Compare
4d19ec4
into
dynatrace-oss:main
7 checks passed
christian-kreuzberger-dtx
pushed a commit
that referenced
this pull request
Oct 27, 2025
* MCP: fix typos of "vulnerabilities" instead of "problems" * Fix davis-copilot integration test * fix and expand on auth integration tests - Original test send-email.integration.test.ts failed because createDtHttpClient now throws the authorization exception, not sendEmail. - Moved authentication test into its own dynatrace-clients.integration.test.ts - Create authorization test for send-email * Fix integration tests for find-monitored-entity - Use findMonitoredEntitiesByName (the old findMonitoredEntityByName no longer exists) - Result is no longer a string, but a DqlExecutionResult - Fix when no entities provided (throw exception) - Removed test for empty string (instead have test for empty list of entities)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests were failing - this PR fixes them.