fix: trade history fallback to fills on error#2089
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dankim214
reviewed
Feb 27, 2026
Comment on lines
+130
to
+137
| ? [ | ||
| FillsTableColumnKey.Time, | ||
| FillsTableColumnKey.Market, | ||
| FillsTableColumnKey.Action, | ||
| FillsTableColumnKey.TypeAmount, | ||
| FillsTableColumnKey.PriceFee, | ||
| FillsTableColumnKey.ClosedPnl, | ||
| ] |
Collaborator
There was a problem hiding this comment.
just checking if this looks okay- noticed previously we rendered a lot less for the Fills table https://github.com/dydxprotocol/v4-web/pull/2087/changes#diff-0f6dfa81a8750b4e617f5b5f25e72ca543613f3c19ad816ac72b4b7305bf05c7L121-L123
Contributor
Author
There was a problem hiding this comment.
they should be fine but removing them regardless and need to update the list/rows as well before this can merge
dankim214
previously approved these changes
Feb 27, 2026
dankim214
left a comment
Collaborator
There was a problem hiding this comment.
Just a question otherwise lgtm
dankim214
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes