Skip to content

Support SNI in duo client #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AaronAtDuo merged 3 commits into from
Apr 20, 2023
Merged

Support SNI in duo client #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d9dd80
Pass server hostname to SSLContext.wrap_socket in order to support co…
ccassell Apr 12, 2023
b367ca2
Add test for host with port
ccassell Apr 19, 2023
f296721
Merge branch 'master' into duo-client-sni
ccassell Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion duo_client/https_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ def connect(self):
self.timeout)
if self._tunnel_host:
self._tunnel()
self.sock = self.default_ssl_context.wrap_socket(self.sock)
self.sock = self.default_ssl_context.wrap_socket(self.sock,
server_hostname=self.host)
if self.default_ssl_context.verify_mode == ssl.CERT_REQUIRED:
cert = self.sock.getpeercert()
cert_validation_host = self._tunnel_host or self.host
Expand Down
14 changes: 14 additions & 0 deletions tests/test_https_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,17 @@ def test_ssl2_ssl3_off(self):
conn = CertValidatingHTTPSConnection('api-fakehost.duosecurity.com')
self.assertEqual(conn.default_ssl_context.options & ssl.OP_NO_SSLv2, ssl.OP_NO_SSLv2)
self.assertEqual(conn.default_ssl_context.options & ssl.OP_NO_SSLv3, ssl.OP_NO_SSLv3)

@mock.patch('socket.socket.connect')
def test_server_hostname(self, mock_connect):
hostname = 'api-fakehost.duosecurity.com'
conn = CertValidatingHTTPSConnection(hostname)
conn.connect()
self.assertEqual(conn.sock.server_hostname, hostname)

@mock.patch('socket.socket.connect')
def test_server_hostname_with_port(self, mock_connect):
hostname = 'api-fakehost.duosecurity.com'
conn = CertValidatingHTTPSConnection(f'{hostname}:443')
conn.connect()
self.assertEqual(conn.sock.server_hostname, hostname)