Added _ca_certs property to _SSLAdapter to properly support pickling (broke in SDK v11.33)#440
Merged
mover333 merged 2 commits intodropbox:mainfrom Aug 4, 2022
Merged
Conversation
Contributor
Author
|
The Code of Conduct seems broken guys, HTTP 403: https://opensource.dropbox.com/coc/ |
This was referenced Jul 27, 2022
Contributor
Author
|
I pre-ran the tests on my fork, most succeed, but some integration tests are failing (on purpose?): |
Contributor
|
Thanks! I'll ask the team to review this (as well as check on that 403 on the COC). |
mover333
approved these changes
Aug 4, 2022
mover333
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the new test case :)
Contributor
Author
|
Great, thanks! |
Contributor
|
This is released in v11.34.0 now. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Dropbox SDK v11.33 PR #385 added a new
_ca_certsproperty to_SSLAdapter.However, the property is dynamically specified, which breaks unpickling it using
pickle.loads():The fix is simple: Define the property instead of dynamically defining it.
Checklist
General Contributing
Is This a Code Change?
Non-code related change (markdown/git settings etc)Example/Test Code ChangeValidation
toxpass?