fix: Add missing inline import plugin install steps#687
Open
klmkyo wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Drizzle ORM docs for Expo/React Native + migrations to include the missing installation step for babel-plugin-inline-import, and standardizes package install snippets to use the shared <Npm> MDX helper instead of hardcoded npm commands.
Changes:
- Add an explicit “Install babel plugin” step to the Expo and OP-SQLite get-started guides.
- Replace inline
npm install ...code fences with the<Npm>helper in the related SQLite connection guides and a release note. - Add the missing
import Npm from "@mdx/Npm.astro";where needed.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/content/docs/sqlite/connect-op-sqlite.mdx | Replaces the hardcoded npm install snippet with <Npm> for the inline-import plugin step. |
| src/content/docs/sqlite/connect-expo-sqlite.mdx | Replaces the hardcoded npm install snippet with <Npm> for the inline-import plugin step. |
| src/content/docs/latest-releases/drizzle-orm-v0292.mdx | Switches the inline-import install snippet to <Npm> and adds the required Npm import. |
| src/content/docs/get-started/op-sqlite-new.mdx | Adds a missing “Install babel plugin” step using <Npm> and renumbers subsequent steps. |
| src/content/docs/get-started/expo-new.mdx | Adds a missing “Install babel plugin” step using <Npm> and renumbers subsequent steps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+64
to
+66
| <Npm> | ||
| babel-plugin-inline-import | ||
| </Npm> |
Author
There was a problem hiding this comment.
Without the copilot suggested change:
With the copilot suggested change (the indentation on 1. is inconsistent):
I'm assuming that this suggestion should be ignored then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting up a mobile app with Drizzle migrations,
babel.config.jsreferences theinline-importBabel plugin, but the Expo and OP-SQLite docs are missing a step to installbabel-plugin-inline-import, despite the exact step being present in other, similiar docs.This PR adds this missing install step to:
/docs/get-started/expo-new.mdx/docs/get-started/op-sqlite-new.mdxThe added section follows the already established pattern used in:
/docs/sqlite/connect-expo-sqlite.mdx/docs/sqlite/connect-op-sqlite.mdx/docs/latest-releases/drizzle-orm-v0292.mdxAdditionally, in all 5 pages, instead of hardcoding the
npmmanager, a change was made to use the<Npm>helper.Before:
After: