Make CloudPath.is_valid_cloudpath a TypeGuard (#337)#338
Merged
Conversation
This allows us to infer that CloudPaths are the same type of object as the class is_valid_cloudpath is called on
Contributor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #338 +/- ##
========================================
- Coverage 94.2% 94.1% -0.1%
========================================
Files 22 22
Lines 1473 1484 +11
========================================
+ Hits 1388 1397 +9
- Misses 85 87 +2
|
Member
Author
|
Thanks @ringohoffman |
|
Could we release a patch for this + #336? I'd really like to consume them! |
msmitherdc
pushed a commit
to CRREL/cloudpathlib
that referenced
this pull request
Feb 22, 2025
…ivendataorg#338) This allows us to infer that CloudPaths are the same type of object as the class is_valid_cloudpath is called on Co-authored-by: Matthew Hoffman <matthew@protopia.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to infer that CloudPaths are the same type of object as the class is_valid_cloudpath is called on
Local version of #337 for live tests