Enable nullability in Glyph classes and BehaviorService#9341
Merged
dreddy-work merged 3 commits intodotnet:mainfrom Jun 26, 2023
Merged
Enable nullability in Glyph classes and BehaviorService#9341dreddy-work merged 3 commits intodotnet:mainfrom
dreddy-work merged 3 commits intodotnet:mainfrom
Conversation
dreddy-work
reviewed
Jun 22, 2023
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/BehaviorService.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/BehaviorService.cs
Outdated
Show resolved
Hide resolved
| IUIService uiService = (IUIService)_serviceProvider.GetService(typeof(IUIService)); | ||
| if (uiService is not null) | ||
| IUIService? uiService = _serviceProvider.GetService<IUIService>(); | ||
| IWin32Window? hwnd = uiService?.GetDialogOwnerWindow(); |
Member
There was a problem hiding this comment.
technically, existing code is more optimized. hwnd won't be declared if uiService is null.
Contributor
Author
There was a problem hiding this comment.
I tried to keep it short and optimized with pattern matching to address your comment
| Behavior? behavior = GetAppropriateBehavior(_hitTestedGlyph); | ||
|
|
||
| if (behavior is not null) | ||
| { |
Member
There was a problem hiding this comment.
Would be nice if this if block on line 564 can be optimized.
Contributor
Author
There was a problem hiding this comment.
Reading it again, nothing obvious comes to mind unfortunately
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/BehaviorService.cs
Outdated
Show resolved
Hide resolved
dreddy-work
approved these changes
Jun 26, 2023
This was referenced Jul 3, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Glyph,GlyphCollection,ToolStripItemGlyphandBehaviorServiceMicrosoft Reviewers: Open in CodeFlow