Use Unsafe.AsRef to implement UnsafeNativeMethods.PtrToRef#898
Merged
zsd4yr merged 1 commit intodotnet:masterfrom May 15, 2019
Merged
Use Unsafe.AsRef to implement UnsafeNativeMethods.PtrToRef#898zsd4yr merged 1 commit intodotnet:masterfrom
zsd4yr merged 1 commit intodotnet:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #898 +/- ##
===================================================
+ Coverage 28.83584% 28.84162% +0.00578%
===================================================
Files 1078 1078
Lines 293919 293919
Branches 38408 38408
===================================================
+ Hits 84754 84771 +17
+ Misses 205131 205110 -21
- Partials 4034 4038 +4
|
zsd4yr
reviewed
May 10, 2019
Contributor
zsd4yr
left a comment
There was a problem hiding this comment.
@JeremyKuhne would you mind taking a look? It looks good to me :)
JeremyKuhne
approved these changes
May 15, 2019
zsd4yr
approved these changes
May 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #818, per a request in #835 (comment).