Skip to content

Remove redundant defines#838

Merged
zsd4yr merged 2 commits intodotnet:masterfrom
danmoseley:win95
Apr 22, 2019
Merged

Remove redundant defines#838
zsd4yr merged 2 commits intodotnet:masterfrom
danmoseley:win95

Conversation

@danmoseley
Copy link
Member

@danmoseley danmoseley commented Apr 21, 2019

WIN95_SUPPORT - It is always defined in this project, which contains the only use of it.
WINDOWS_FORMS_SWITCHES - It is always defined, and build fails if it is not defined.

Relates to #39

@danmoseley danmoseley requested a review from a team as a code owner April 21, 2019 04:26
@danmoseley danmoseley changed the title Remove Win95 define Remove redundant defines Apr 21, 2019
@codecov
Copy link

codecov bot commented Apr 21, 2019

Codecov Report

Merging #838 into master will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##              master        #838   +/-   ##
=============================================
  Coverage   28.05148%   28.05148%           
=============================================
  Files           1065        1065           
  Lines         292530      292530           
  Branches       38519       38519           
=============================================
  Hits           82059       82059           
+ Misses        206414      206411    -3     
- Partials        4057        4060    +3
Flag Coverage Δ
#Debug 28.05148% <ø> (ø) ⬆️
#production 18.36569% <ø> (ø) ⬆️
#test 98.66795% <ø> (ø) ⬆️

@danmoseley
Copy link
Member Author

Again I now see that @hughbe has some or all of this.

Copy link
Contributor

@zsd4yr zsd4yr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small, succinct changes. Thanks for the easy review! LGTM

@zsd4yr zsd4yr merged commit 5744928 into dotnet:master Apr 22, 2019
@danmoseley danmoseley deleted the win95 branch April 24, 2019 00:07
@ghost ghost locked as resolved and limited conversation to collaborators Feb 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants