Merged
Conversation
Contributor
Author
|
Only ready to review after #674 is merged |
35b5ab3 to
505e0b5
Compare
Codecov Report
@@ Coverage Diff @@
## master #691 +/- ##
==================================================
+ Coverage 24.52205% 25.8069% +1.28485%
==================================================
Files 1026 1027 +1
Lines 284132 287365 +3233
Branches 38424 38482 +58
==================================================
+ Hits 69675 74160 +4485
+ Misses 210557 209234 -1323
- Partials 3900 3971 +71
|
Contributor
505e0b5 to
38152c3
Compare
zsd4yr
approved these changes
Apr 15, 2019
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Depends on #674
Fixes #690