Skip to content

Add ListControl tests#691

Merged
zsd4yr merged 3 commits intodotnet:masterfrom
hughbe:listcontrol-tests
Apr 15, 2019
Merged

Add ListControl tests#691
zsd4yr merged 3 commits intodotnet:masterfrom
hughbe:listcontrol-tests

Conversation

@hughbe
Copy link
Contributor

@hughbe hughbe commented Apr 6, 2019

Depends on #674

Fixes #690

@hughbe hughbe requested a review from a team as a code owner April 6, 2019 08:06
@hughbe
Copy link
Contributor Author

hughbe commented Apr 6, 2019

Only ready to review after #674 is merged

@hughbe hughbe force-pushed the listcontrol-tests branch 7 times, most recently from 35b5ab3 to 505e0b5 Compare April 10, 2019 12:41
@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #691 into master will increase coverage by 1.28484%.
The diff coverage is 99.92826%.

@@                Coverage Diff                 @@
##              master       #691         +/-   ##
==================================================
+ Coverage   24.52205%   25.8069%   +1.28485%     
==================================================
  Files           1026       1027          +1     
  Lines         284132     287365       +3233     
  Branches       38424      38482         +58     
==================================================
+ Hits           69675      74160       +4485     
+ Misses        210557     209234       -1323     
- Partials        3900       3971         +71
Flag Coverage Δ
#Debug 25.8069% <99.92826%> (+1.28484%) ⬆️
#production 17.261% <100%> (+0.48333%) ⬆️
#test 98.62179% <99.92652%> (+0.07112%) ⬆️

@zsd4yr
Copy link
Contributor

zsd4yr commented Apr 15, 2019

@hughbe #674 is merged

@hughbe hughbe force-pushed the listcontrol-tests branch from 505e0b5 to 38152c3 Compare April 15, 2019 20:58
@zsd4yr
Copy link
Contributor

zsd4yr commented Apr 15, 2019

a 1% increase in code coverage!

image

@zsd4yr zsd4yr merged commit 1743df9 into dotnet:master Apr 15, 2019
@hughbe hughbe deleted the listcontrol-tests branch April 15, 2019 23:52
@ghost ghost locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ListControl.FilterItemOnProperty(new object(), null) throws NRE should be a nop

2 participants