Skip to content

[master] Update dependencies from dotnet/arcade#612

Merged
dotnet-maestro[bot] merged 4 commits intomasterfrom
darc-master-82aa79bb-e513-45bb-a5d1-2f1156370bce
Mar 20, 2019
Merged

[master] Update dependencies from dotnet/arcade#612
dotnet-maestro[bot] merged 4 commits intomasterfrom
darc-master-82aa79bb-e513-45bb-a5d1-2f1156370bce

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 19, 2019

This pull request updates the following dependencies

Updates from https://github.com/dotnet/arcade

  • Microsoft.DotNet.XUnitExtensions - 2.4.0-beta.19167.10
  • Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19167.10
  • Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19167.10
  • Microsoft.DotNet.GenFacades - 1.0.0-beta.19167.10

From https://github.com/dotnet/arcade

  • Build: 20190317.10
  • Date Produced: 3/18/2019 7:14 AM
  • Commit: de7be3ba62b92e5c48c36876c851a14f154444af
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.DotNet.XUnitExtensions -> 2.4.0-beta.19167.10
    • Microsoft.DotNet.Arcade.Sdk -> 1.0.0-beta.19167.10
    • Microsoft.DotNet.Helix.Sdk -> 2.0.0-beta.19167.10
    • Microsoft.DotNet.GenFacades -> 1.0.0-beta.19167.10

…317.10

This change updates the following dependencies
- Microsoft.DotNet.XUnitExtensions - 2.4.0-beta.19167.10
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19167.10
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19167.10
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19167.10
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner March 19, 2019 12:04
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Mar 19, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: dotnet-winforms CI

@zsd4yr
Copy link
Contributor

zsd4yr commented Mar 19, 2019

@markwilkie @Chrisboh @alexperovich Looks like a breaking change to publish?

@dotnet-maestro
Copy link
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: dotnet-winforms CI

@markwilkie
Copy link
Member

What was the break?

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Mar 19, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: dotnet-winforms CI

@alexperovich
Copy link
Member

I believe the break was caused by this: dotnet/arcade#2003. The build is complaining about PackageLicenseUrl.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Mar 19, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: dotnet-winforms CI

@markwilkie
Copy link
Member

@tmat - can you give @zsd4yr a hand here to resolve this please?

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Mar 19, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: dotnet-winforms CI

@tmat
Copy link
Member

tmat commented Mar 19, 2019

@markwilkie Sure. Looking.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Mar 19, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: dotnet-winforms CI

@tmat
Copy link
Member

tmat commented Mar 19, 2019

I have a fix but can't push it to this PR :(

winforms>git push
remote: Permission to dotnet/winforms.git denied to tmat.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Mar 19, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: dotnet-winforms CI

@zsd4yr
Copy link
Contributor

zsd4yr commented Mar 19, 2019

@tmat I have added you as a collaborator with write-level access. You should be able to push to this PR now.

@zsd4yr
Copy link
Contributor

zsd4yr commented Mar 19, 2019

Thanks @markwilkie for the expedient response 😄

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Mar 19, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: dotnet-winforms CI

@tmat
Copy link
Member

tmat commented Mar 19, 2019

@zsd4yr Pushed a commit. PTAL

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Mar 19, 2019

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

  • ✔️ All Checks Successful Succeeded - Successful checks: dotnet-winforms CI

@dotnet-maestro dotnet-maestro bot merged commit 177af61 into master Mar 20, 2019
@dotnet-maestro dotnet-maestro bot deleted the darc-master-82aa79bb-e513-45bb-a5d1-2f1156370bce branch March 20, 2019 18:35
@JuditRose
Copy link
Contributor

Thanks @tmat for the fix

@JuditRose
Copy link
Contributor

After merging this in the CI build broke: https://dev.azure.com/dnceng/internal/_build/results?buildId=128847
It fails at the publish step with this message:

_PublishUsingPipelines : The term '_PublishUsingPipelines' is not recognized as the name of a cmdlet, function, script 
file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct 
and try again.
At D:\a\_temp\427826e6-3611-449e-b31d-1825de37b31a.ps1:2 char:298
+ ... p.azure.com /p:PublishUsingPipelines=$(_PublishUsingPipelines) /p:Con ...
+                                            ~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (_PublishUsingPipelines:String) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : CommandNotFoundException
 
##[error]PowerShell exited with code '1'.

JuditRose added a commit that referenced this pull request Mar 20, 2019
JuditRose added a commit that referenced this pull request Mar 20, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants