Skip to content

Modernize folderdialog#57

Merged
shanselman merged 10 commits intodotnet:masterfrom
clairernovotny:modernize-folderdialog
Dec 4, 2018
Merged

Modernize folderdialog#57
shanselman merged 10 commits intodotnet:masterfrom
clairernovotny:modernize-folderdialog

Conversation

@clairernovotny
Copy link

@clairernovotny clairernovotny commented Nov 16, 2018

This PR fixes #1 by implementing a Vista-style folder dialog.

Current dialog:
image

With this PR, the Vista-style dialog:
image

@merriemcgaw
Copy link
Member

Can we see some Unit Tests with this PR? @AdamYoblick and @zsd4yr have some examples elswhere in WinForms.

@clairernovotny
Copy link
Author

@merriemcgaw I would love to have some unit tests for this, but it was unclear how that can be accomplished. I was waiting for an example or the scaffolding of a unit test project to be available.

Also, I thought the tests @AdamYoblick were pretty basic and not UI tests. The Dialog blocks the calling thread and needs UI automation to manipulate it. I fully agree on the need for tests, just had not seen any infrastructure for adding one in yet.

@clairernovotny
Copy link
Author

I can certainly add something to https://github.com/dotnet/winforms/tree/master/src/System.Windows.Forms/tests/functests if the p2p ref works now; I know that was being looked into before.

@clairernovotny clairernovotny requested a review from a team as a code owner November 25, 2018 22:51
@merriemcgaw
Copy link
Member

@onovotny Could you possibly provide before and after screenshots of the Folder dialog.

@AdamYoblick AdamYoblick closed this Dec 4, 2018
@AdamYoblick AdamYoblick reopened this Dec 4, 2018
@clairernovotny
Copy link
Author

@merriemcgaw Done

@shanselman shanselman merged commit 5822e88 into dotnet:master Dec 4, 2018
@shanselman
Copy link
Contributor

:shipit:

@LanceMcCarthy
Copy link

This was an epic PR

@daniel-white
Copy link

Awesome to see this sort of transparency w/ Windows Forms!

@clairernovotny clairernovotny deleted the modernize-folderdialog branch December 4, 2018 17:36
@mattiascibien
Copy link

Been waiting for this since Windows Vista 👍

@orange-pig
Copy link

Epic update

@samuelGrahame
Copy link

This is amazing

@KevinAdams05
Copy link

Was the icon updated? The screenshot shows that it has the default form icon.

@samuelGrahame
Copy link

Was the icon updated? The screenshot shows that it has the default form icon.

maybe it gets it from the running program, but good point.

@RussKie RussKie added the 📖 documentation: breaking please open a breaking change issue https://github.com/dotnet/docs/issues/new?assignees=gewarren label Aug 12, 2019
@RussKie
Copy link
Contributor

RussKie commented Sep 2, 2019

docs - dotnet/docs#14153

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

📖 documentation: breaking please open a breaking change issue https://github.com/dotnet/docs/issues/new?assignees=gewarren

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modernize FolderBrowserDialog