Stop NativeImageList GDI leak (servicing)

[RussKie]

Fixes #3567
Fixes #4913
Closes #4316
Closes #4928

Proposed changes

There are certain code paths where we are unable to track the lifetime of the object,
for example in the following scenarios:

 this.imageList1.ImageStream = (System.Windows.Forms.ImageListStreamer)(resources.GetObject("imageList1.ImageStream"));

or

 resources.ApplyResources(this.listView1, "listView1");

In those cases the loose instances will be collected by the GC.

Undo the regression introduced in #3526.

Customer Impact

• Customer applications should no longer crash due to exhausted pool of GDI handles used by NativeImageList objects.

Regression?

• Yes

Risk

• Minimal

Test methodology

• added unit and MAUI tests to verify both disposal and GC scenarios
• a lot of manual tests

Manual tests harness:

diff --git a/src/System.Windows.Forms/tests/IntegrationTests/WinformsControlsTest/MainForm.cs b/src/System.Windows.Forms/tests/IntegrationTests/WinformsControlsTest/MainForm.cs
index 02ed97ff4..68d0ef6db 100644
--- a/src/System.Windows.Forms/tests/IntegrationTests/WinformsControlsTest/MainForm.cs
+++ b/src/System.Windows.Forms/tests/IntegrationTests/WinformsControlsTest/MainForm.cs
@@ -123,7 +123,18 @@ namespace WinformsControlsTest
             },
             {
                 MainFormControlsTabOrder.ListViewButton,
-                new InitInfo("ListVew", (obj, e) => new ListViewTest().Show())
+                new InitInfo("ListVew", (obj, e) =>
+                {
+                    int gdiHandleCount = Interop.User32.GetGuiResources(Process.GetCurrentProcess().Handle, Interop.User32.GR.GDIOBJECTS);
+                    Debug.WriteLine($"before: {gdiHandleCount}");
+                    using ListViewTest form = new ();
+                    form.ShowDialog();
+                    GC.Collect();
+                    GC.WaitForPendingFinalizers();
+                    GC.Collect(0);
+                    gdiHandleCount = Interop.User32.GetGuiResources(Process.GetCurrentProcess().Handle, Interop.User32.GR.GDIOBJECTS);
+                    Debug.WriteLine($"after: {gdiHandleCount}");
+                })
             },

Before

After

Microsoft Reviewers: Open in CodeFlow

[RussKie]

Approved for servicing over the email

[codecov]

Codecov Report

Merging #4975 (c02bf45) into release/5.0 (9fb50b3) will decrease coverage by 0.01164%.
The diff coverage is 91.66667%.

@@                  Coverage Diff                  @@
##           release/5.0       #4975         +/-   ##
=====================================================
- Coverage     68.41633%   68.40469%   -0.01164%     
=====================================================
  Files             1421        1422          +1     
  Lines           511052      511060          +8     
  Branches         41587       41586          -1     
=====================================================
- Hits            349643      349589         -54     
- Misses          154992      155057         +65     
+ Partials          6417        6414          -3     

Flag	Coverage Δ
Debug	68.40469% <91.66667%> (-0.01164%)	⬇️
production	37.83160% <80.00000%> (-0.02446%)	⬇️
test	97.90758% <100.00000%> (+0.00005%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.