Replace EnumValidator - Unit Tests and Changing the Validator

[wreuel]

Fixes #4639

Proposed changes

• Created tests to Label and RadioButton
• Remove Enum Validator on class

Customer Impact

• None

Regression?

• No

Risk

• None

Test methodology

• Unit Tests created before change

.NET SDK (reflecting any global.json):
Version: 6.0.100-preview.2.21155.3
Commit: 1a9103db2d

Runtime Environment:
OS Name: Windows
OS Version: 10.0.19042
OS Platform: Windows
RID: win10-x64
Base Path: C:\Program Files\dotnet\sdk\6.0.100-preview.2.21155.3\

Host (useful for support):
Version: 6.0.0-preview.2.21154.6
Commit: 3eaf1f316b

.NET SDKs installed:
3.1.407 [C:\Program Files\dotnet\sdk]
5.0.104 [C:\Program Files\dotnet\sdk]
5.0.201 [C:\Program Files\dotnet\sdk]
6.0.100-preview.2.21155.3 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
Microsoft.AspNetCore.All 2.1.26 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.26 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.13 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 5.0.4 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.0-preview.2.21154.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.26 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.13 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.4 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 6.0.0-preview.2.21154.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.1.6 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 3.1.13 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 5.0.4 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 6.0.0-preview.2.21154.2 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Microsoft Reviewers: Open in CodeFlow

[wreuel]

@RussKie I couldn't do the squash to my 4 PR Merge (To Update my Fork), I did get it why, but I did for a new with all the code done. If you can recommend a doc or video on how to do the squash or on how to update my Fork, I would be gratefull.

[RussKie]

There was no reason to close the other PR 😉
Please have a look at these guidelines, hopefully you'd find them helpful.

[RussKie]

You still have 4 unrelated commits in the PR. The easiest way to remove those is to perform an interactive rebase on top of the latest main branch, dropping the unrelated commits.
It would look something like this:

1. Fetch the latest main, e.g. git fetch --progress "remote" +refs/heads/main
2. Rebase on to the latest main, e.g. git -c rebase.autoSquash=false rebase -i --autosquash <sha of the latest main HEAD>
3. In the dialog drop irrelevant commits, e.g.
   
4. Force-push back into your fork.

[wreuel]

Sorry my delay @RussKie, but now I think is good to go!

[AraHaan]

After thinking about it, should this get merged when #4809 is done? I will try to get it done as soon as I fix #4751 so then it will also unblock #4746.

But then again perhaps #4809 should be merged first, then this one rebase on top of that, and then that way this would remove that entire EnumValidator class the rest of the way.

[RussKie]

👍
Few comments

[RussKie]

@wreuel a friendly nudge

[wreuel]

@RussKie got a problem with my pc, and in the end I forgot this, gonna fix this week! 😃

[ghost]

Hello @RussKie!

Because this pull request has the :octocat: automerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

Happy to oblige